This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "[display_list] grow display list backing store by power of two. (#56004)" #56078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
approved these changes
Oct 24, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 24, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 24, 2024
flutter/engine@0b56cb8...be56084 2024-10-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[display_list] grow display list backing store by power of two. (#56004)" (flutter/engine#56078) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC codefu@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
M97Chahboun
pushed a commit
to M97Chahboun/flutter
that referenced
this pull request
Oct 30, 2024
) flutter/engine@0b56cb8...be56084 2024-10-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[display_list] grow display list backing store by power of two. (flutter#56004)" (flutter/engine#56078) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC codefu@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…wo. (flutter#56004)" (flutter/engine#56078) Reverts: flutter/engine#56004 Initiated by: jonahwilliams Reason for reverting: unexpected framework ui thread regression, no performance improvement Original PR Author: jonahwilliams Reviewed By: {flar, chinmaygarde} This change reverts the following previous change: Fixes flutter#157108 Right now the DL is always growing by a minimum 4096 bytes at a time. On applications with large display lists, this can lead to hundreds of reallocations as the display list is build, as long as each draw op is small. For example, the framework benchmark long picture scrolling draws many lines, each of which is a pretty small op. Update the code so that we grow by doubling, with a minimum increment of ~16K
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #56004
Initiated by: jonahwilliams
Reason for reverting: unexpected framework ui thread regression, no performance improvement
Original PR Author: jonahwilliams
Reviewed By: {flar, chinmaygarde}
This change reverts the following previous change:
Fixes flutter/flutter#157108
Right now the DL is always growing by a minimum 4096 bytes at a time. On applications with large display lists, this can lead to hundreds of reallocations as the display list is build, as long as each draw op is small. For example, the framework benchmark long picture scrolling draws many lines, each of which is a pretty small op.
Update the code so that we grow by doubling, with a minimum increment of ~16K