Added retry mechanism for pipeline creation #56071
Conversation
|
@matanlurey can I get an unorthodox test exemption? Testing this code properly would be an investment that won't be worthwhile if this doesn't affect the flakiness. I'd like to test to see if it removes the flakiness first. |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
This code is also ifdef'd out on platforms other than intel mac so the blast radius is ... small. ish. |
|
auto label is removed for flutter/engine/56071, due to - The status or check suite Mac mac_ios_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
2c30e15 to
83881f4
Compare
a6d0389 to
beca13a
Compare
flutter/engine@eb867e0...5061358 2024-10-25 30870216+gaaclarke@users.noreply.github.com renamed TextFrameDispatcher to FirstPassDispatcher (flutter/engine#56098) 2024-10-25 30870216+gaaclarke@users.noreply.github.com Added retry mechanism for pipeline creation (flutter/engine#56071) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC codefu@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
issue flutter#157467 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
issue flutter/flutter#157467
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.