This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland copy gen snapshot #56061
Merged
Reland copy gen snapshot #56061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lutter#55830)" This reverts commit 78f4ffa as it addresses the issues with copying over existing link.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 23, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 23, 2024
flutter/engine@6b022df...19f9c5a 2024-10-23 skia-flutter-autoroll@skia.org Roll Skia from ad09ab099fe4 to 721bbd7c0340 (10 revisions) (flutter/engine#56063) 2024-10-23 aam@google.com Reland copy gen snapshot (flutter/engine#56061) 2024-10-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 2a4b728f6a03 to 75c42f30af7a (1 revision) (flutter/engine#56060) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC codefu@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
M97Chahboun
pushed a commit
to M97Chahboun/flutter
that referenced
this pull request
Oct 30, 2024
…7460) flutter/engine@6b022df...19f9c5a 2024-10-23 skia-flutter-autoroll@skia.org Roll Skia from ad09ab099fe4 to 721bbd7c0340 (10 revisions) (flutter/engine#56063) 2024-10-23 aam@google.com Reland copy gen snapshot (flutter/engine#56061) 2024-10-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 2a4b728f6a03 to 75c42f30af7a (1 revision) (flutter/engine#56060) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC codefu@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
Copy gen_snapshots using python's shutil.copy, avoid links
Default implementation of copy does it via hardlink, which seems to be
causing issues with Gatekeeper on mac.
This is reland of 63d8f5c with the fix
for the case when target is a link to the source, that was the cause for
revert c5ad234
BUG=flutter#154437
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy gen_snapshots using python's shutil.copy, avoid links
Default implementation of copy does it via hardlink, which seems to be causing issues with Gatekeeper on mac.
This is reland of 6c4f05c with the fix for the case when target is a link to the source, that was the cause for revert 78f4ffa
BUG=flutter/flutter#154437