This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Update the engine deps to track new SoT git locations for several packages #56028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The CI's green now; fyi that I have less familiarity w/ the necessary updates to the license script / goldens. |
zanderso
reviewed
Oct 23, 2024
zanderso
approved these changes
Oct 23, 2024
matanlurey
approved these changes
Oct 23, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 23, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 23, 2024
flutter/engine@19f9c5a...73c54fa 2024-10-23 skia-flutter-autoroll@skia.org Roll Skia from 721bbd7c0340 to 42f9070e6625 (1 revision) (flutter/engine#56064) 2024-10-23 devoncarew@google.com Update the engine deps to track new SoT git locations for several packages (flutter/engine#56028) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC codefu@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
M97Chahboun
pushed a commit
to M97Chahboun/flutter
that referenced
this pull request
Oct 30, 2024
…7464) flutter/engine@19f9c5a...73c54fa 2024-10-23 skia-flutter-autoroll@skia.org Roll Skia from 721bbd7c0340 to 42f9070e6625 (1 revision) (flutter/engine#56064) 2024-10-23 devoncarew@google.com Update the engine deps to track new SoT git locations for several packages (flutter/engine#56028) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC codefu@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…kages (flutter/engine#56028) This PR updates the deps and pubspec overrides to track the new SoT of several Dart core packages (these now live in dart-lang/core). - `package:args` - `package:async` - `package:convert` - `package:crypto` - `package:fixnum` - `package:logging` - `package:path` - `package:platform` - `package:typed_data` issues - dart-lang/sdk#56591 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the deps and pubspec overrides to track the new SoT of several Dart core packages (these now live in dart-lang/core).
package:argspackage:asyncpackage:convertpackage:cryptopackage:fixnumpackage:loggingpackage:pathpackage:platformpackage:typed_dataissues
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.