This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Flutter GPU] Fix conditional when checking DeviceBuffer bounds. #56017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domesticmouse
approved these changes
Oct 22, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 22, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 22, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 22, 2024
flutter/engine@e685650...b3205a2 2024-10-22 bdero@google.com [Flutter GPU] Fix conditional when checking DeviceBuffer bounds. (flutter/engine#56017) 2024-10-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 86ac62245577 to 8de85635d731 (3 revisions) (flutter/engine#56019) 2024-10-22 skia-flutter-autoroll@skia.org Roll Skia from 64f4f1922946 to c89324dd8f6e (1 revision) (flutter/engine#56018) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC codefu@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
M97Chahboun
pushed a commit
to M97Chahboun/flutter
that referenced
this pull request
Oct 30, 2024
…7348) flutter/engine@e685650...b3205a2 2024-10-22 bdero@google.com [Flutter GPU] Fix conditional when checking DeviceBuffer bounds. (flutter/engine#56017) 2024-10-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 86ac62245577 to 8de85635d731 (3 revisions) (flutter/engine#56019) 2024-10-22 skia-flutter-autoroll@skia.org Roll Skia from 64f4f1922946 to c89324dd8f6e (1 revision) (flutter/engine#56018) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC codefu@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…tter/engine#56017) Resolves flutter#157324 Fix a silly off-by-one that I didn't catch because none of the tests are using `DeviceBuffer` directly. ð�¤¦
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves flutter/flutter#157324
Fix a silly off-by-one that I didn't catch because none of the tests are using
DeviceBufferdirectly. 🤦