Remove unnecessary use of std::vector #55796
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
test-exempt: code refactor with no semantic change |
|
Won't we just need to undo this when we add support for multiple displays? |
I'd imagine so, but I think it's reasonable to clean up until we get there. If there's an open bug for this, it's probably worth adding a |
flutter/engine@fdc667e...01e247a 2024-10-14 robert.ancell@canonical.com Use GWeakRef API (flutter/engine#55795) 2024-10-14 robert.ancell@canonical.com Remove unnecessary use of std::vector (flutter/engine#55796) 2024-10-14 robert.ancell@canonical.com Remove fl_keyboard_view_delegate_subscribe_to_layout_change and just access the object directly via a method (flutter/engine#55817) 2024-10-13 robert.ancell@canonical.com Split out FlKeyboardLayout into its own class (flutter/engine#55816) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
No description provided.