This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix dispose methods that didn't chain the parent. #55794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove empty dispose methods and convert finalize methods to dispose for consistency.
cbracken
approved these changes
Oct 11, 2024
Member
There was a problem hiding this comment.
Just for my own GTK knowledge, would you say the following is a good summary of dispose vs finalize?
https://mail.gnome.org/archives/gtk-devel-list/2004-July/msg00151.html
Contributor
Author
That's also my understanding, however if you use g_clear_object/g_clear_pointer then you can safely remove everything in the dispose method (because this ensures they are only freed once) and this makes things a lot simpler than having to have both. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 13, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 13, 2024
flutter/engine@8fdc6a8...adc5909 2024-10-13 robert.ancell@canonical.com Make FlRenderable interface (flutter/engine#55763) 2024-10-13 robert.ancell@canonical.com Fix dispose methods that didn't chain the parent. (flutter/engine#55794) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
Remove empty dispose methods and convert finalize methods to dispose for consistency.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove empty dispose methods and convert finalize methods to dispose for consistency.