This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Use the right versioned libs according to the target-api-level #55786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Yes, it's weird, I cannot tell why Mac and Linux are so unhappy. I retried them and two are still failing. |
zanderso
approved these changes
Oct 11, 2024
Contributor
Author
|
Awesome, tests passed, thank you guys. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 11, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 11, 2024
flutter/engine@d13cbfb...bc3b180 2024-10-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Fuchsia] Use more high level fuchsia-gn-sdk templates (#55445)" (flutter/engine#55834) 2024-10-11 chinmaygarde@google.com [Impeller] libImpeller: Fix missing exports on some paint methods. (flutter/engine#55814) 2024-10-11 6844906+zijiehe-google-com@users.noreply.github.com [fuchsia] Use the right versioned libs according to the target-api-level (flutter/engine#55786) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…vel (flutter/engine#55786) Except for the vulkan, target-api-level should control the versions of the other libraries rather than the ones in ToT (//fuchsia/sdk/$host_os/arch/$target_cpu/dist). FYI: @hjfreyer Bug: http://b/40935282 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Except for the vulkan, target-api-level should control the versions of the other libraries rather than the ones in ToT (//fuchsia/sdk/$host_os/arch/$target_cpu/dist).
FYI: @hjfreyer
Bug: http://b/40935282
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.