This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] add basic Impeller+Vulkan support to embedder API. #55490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Integration with context vk is a bit messy, since the emebdder expects to provide a lot of objects that context vk was already creating. |
Contributor
|
@jonahwilliams awesome 👍. I'll test it out when I'm back in the office; October 14th. |
Contributor
|
Also I haven't looked into it yet, but using the compositor interface bypasses some of the embedder API; Fuschia dev mentioned this. My plans include moving to the compositor interface in the near future. |
Contributor
Author
|
Sorry I don't follow |
chinmaygarde
approved these changes
Oct 28, 2024
| auto proc_addr = | ||
| vulkan_get_instance_proc_address(vk_instance, "vkGetInstanceProcAddr"); | ||
|
|
||
| std::shared_ptr<flutter::EmbedderExternalViewEmbedder> view_embedder = |
Contributor
There was a problem hiding this comment.
Unrelated: The embedder.cc entrypoint is becoming a monster. We should separate it out into different TUs for easier perursal.
| break; | ||
| if (enable_impeller) { | ||
| FML_LOG(ERROR) << "Unimplemented"; | ||
| break; |
Contributor
There was a problem hiding this comment.
IIRC, this should return nullptr. That should return the right error code to the embedder. We can file a bug for followup.
Contributor
Author
There was a problem hiding this comment.
Breaking here leaves the render_target unique_ptr as nullptr which accomplishes the same thing
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 28, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 29, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 29, 2024
flutter/engine@ed587dc...b394e0c 2024-10-29 skia-flutter-autoroll@skia.org Roll Dart SDK from c9180e9de9e8 to 6e55dfe77483 (1 revision) (flutter/engine#56184) 2024-10-28 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Deduplicate golden test file names (flutter/engine#56143) 2024-10-28 bdero@google.com [Flutter GPU] Replace HostBuffer with Dart version. (flutter/engine#56054) 2024-10-28 jonahwilliams@google.com [Impeller] add basic Impeller+Vulkan support to embedder API. (flutter/engine#55490) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC codefu@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…r/engine#55490) Works on GLFW example app with no validation errors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works on GLFW example app with no validation errors.