This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Flutter GPU] Add pipeline stencil config. #55272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
3df2588 to
37cd5e7
Compare
Member
Author
|
Gentle ping @chinmaygarde . :) This is more of the same. Just filling out the missing stencil state. |
chinmaygarde
approved these changes
Sep 24, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 25, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 25, 2024
flutter/engine@559f2ff...746ce61 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 7af8c4882e07 to eda9ae15367e (2 revisions) (flutter/engine#55417) 2024-09-25 bdero@google.com [Flutter GPU] Add CullMode. (flutter/engine#55409) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 2e92f0b443f4 to 3541cdf2fae6 (1 revision) (flutter/engine#55412) 2024-09-24 jonahwilliams@google.com [Impeller] fix Impeller on windows. (flutter/engine#55323) 2024-09-24 jonahwilliams@google.com [Impeller] add basic culling checks during text frame dispatcher. (flutter/engine#55168) 2024-09-24 matanlurey@users.noreply.github.com Move each dart GN rule to a standalone file. (flutter/engine#55404) 2024-09-24 skia-flutter-autoroll@skia.org Roll Skia from 118914b760cb to 2e92f0b443f4 (1 revision) (flutter/engine#55406) 2024-09-24 jonahwilliams@google.com [Impeller] Pack impeller:Path into 2 vecs instead of 3. (flutter/engine#55028) 2024-09-24 codefu@google.com Disallow time traveling frame times (flutter/engine#55310) 2024-09-24 jason-simmons@users.noreply.github.com [Impeller] Delete command pools held by the CommandPoolRecyclerVK after decoding an image on the IO thread (flutter/engine#55398) 2024-09-24 skia-flutter-autoroll@skia.org Roll Skia from cf28f9dd411d to 118914b760cb (1 revision) (flutter/engine#55405) 2024-09-24 bdero@google.com [Flutter GPU] Add pipeline stencil config. (flutter/engine#55272) 2024-09-24 skia-flutter-autoroll@skia.org Roll Skia from 6e5ff9253147 to cf28f9dd411d (1 revision) (flutter/engine#55399) 2024-09-24 jonahwilliams@google.com [Impeller] delete expensive trace event. (flutter/engine#55400) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
…55648) flutter/engine@559f2ff...746ce61 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 7af8c4882e07 to eda9ae15367e (2 revisions) (flutter/engine#55417) 2024-09-25 bdero@google.com [Flutter GPU] Add CullMode. (flutter/engine#55409) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 2e92f0b443f4 to 3541cdf2fae6 (1 revision) (flutter/engine#55412) 2024-09-24 jonahwilliams@google.com [Impeller] fix Impeller on windows. (flutter/engine#55323) 2024-09-24 jonahwilliams@google.com [Impeller] add basic culling checks during text frame dispatcher. (flutter/engine#55168) 2024-09-24 matanlurey@users.noreply.github.com Move each dart GN rule to a standalone file. (flutter/engine#55404) 2024-09-24 skia-flutter-autoroll@skia.org Roll Skia from 118914b760cb to 2e92f0b443f4 (1 revision) (flutter/engine#55406) 2024-09-24 jonahwilliams@google.com [Impeller] Pack impeller:Path into 2 vecs instead of 3. (flutter/engine#55028) 2024-09-24 codefu@google.com Disallow time traveling frame times (flutter/engine#55310) 2024-09-24 jason-simmons@users.noreply.github.com [Impeller] Delete command pools held by the CommandPoolRecyclerVK after decoding an image on the IO thread (flutter/engine#55398) 2024-09-24 skia-flutter-autoroll@skia.org Roll Skia from cf28f9dd411d to 118914b760cb (1 revision) (flutter/engine#55405) 2024-09-24 bdero@google.com [Flutter GPU] Add pipeline stencil config. (flutter/engine#55272) 2024-09-24 skia-flutter-autoroll@skia.org Roll Skia from 6e5ff9253147 to cf28f9dd411d (1 revision) (flutter/engine#55399) 2024-09-24 jonahwilliams@google.com [Impeller] delete expensive trace event. (flutter/engine#55400) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
…55648) flutter/engine@559f2ff...746ce61 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 7af8c4882e07 to eda9ae15367e (2 revisions) (flutter/engine#55417) 2024-09-25 bdero@google.com [Flutter GPU] Add CullMode. (flutter/engine#55409) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 2e92f0b443f4 to 3541cdf2fae6 (1 revision) (flutter/engine#55412) 2024-09-24 jonahwilliams@google.com [Impeller] fix Impeller on windows. (flutter/engine#55323) 2024-09-24 jonahwilliams@google.com [Impeller] add basic culling checks during text frame dispatcher. (flutter/engine#55168) 2024-09-24 matanlurey@users.noreply.github.com Move each dart GN rule to a standalone file. (flutter/engine#55404) 2024-09-24 skia-flutter-autoroll@skia.org Roll Skia from 118914b760cb to 2e92f0b443f4 (1 revision) (flutter/engine#55406) 2024-09-24 jonahwilliams@google.com [Impeller] Pack impeller:Path into 2 vecs instead of 3. (flutter/engine#55028) 2024-09-24 codefu@google.com Disallow time traveling frame times (flutter/engine#55310) 2024-09-24 jason-simmons@users.noreply.github.com [Impeller] Delete command pools held by the CommandPoolRecyclerVK after decoding an image on the IO thread (flutter/engine#55398) 2024-09-24 skia-flutter-autoroll@skia.org Roll Skia from cf28f9dd411d to 118914b760cb (1 revision) (flutter/engine#55405) 2024-09-24 bdero@google.com [Flutter GPU] Add pipeline stencil config. (flutter/engine#55272) 2024-09-24 skia-flutter-autoroll@skia.org Roll Skia from 6e5ff9253147 to cf28f9dd411d (1 revision) (flutter/engine#55399) 2024-09-24 jonahwilliams@google.com [Impeller] delete expensive trace event. (flutter/engine#55400) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 27, 2024
…55648) flutter/engine@559f2ff...746ce61 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 7af8c4882e07 to eda9ae15367e (2 revisions) (flutter/engine#55417) 2024-09-25 bdero@google.com [Flutter GPU] Add CullMode. (flutter/engine#55409) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 2e92f0b443f4 to 3541cdf2fae6 (1 revision) (flutter/engine#55412) 2024-09-24 jonahwilliams@google.com [Impeller] fix Impeller on windows. (flutter/engine#55323) 2024-09-24 jonahwilliams@google.com [Impeller] add basic culling checks during text frame dispatcher. (flutter/engine#55168) 2024-09-24 matanlurey@users.noreply.github.com Move each dart GN rule to a standalone file. (flutter/engine#55404) 2024-09-24 skia-flutter-autoroll@skia.org Roll Skia from 118914b760cb to 2e92f0b443f4 (1 revision) (flutter/engine#55406) 2024-09-24 jonahwilliams@google.com [Impeller] Pack impeller:Path into 2 vecs instead of 3. (flutter/engine#55028) 2024-09-24 codefu@google.com Disallow time traveling frame times (flutter/engine#55310) 2024-09-24 jason-simmons@users.noreply.github.com [Impeller] Delete command pools held by the CommandPoolRecyclerVK after decoding an image on the IO thread (flutter/engine#55398) 2024-09-24 skia-flutter-autoroll@skia.org Roll Skia from cf28f9dd411d to 118914b760cb (1 revision) (flutter/engine#55405) 2024-09-24 bdero@google.com [Flutter GPU] Add pipeline stencil config. (flutter/engine#55272) 2024-09-24 skia-flutter-autoroll@skia.org Roll Skia from 6e5ff9253147 to cf28f9dd411d (1 revision) (flutter/engine#55399) 2024-09-24 jonahwilliams@google.com [Impeller] delete expensive trace event. (flutter/engine#55400) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 27, 2024
…55648) flutter/engine@559f2ff...746ce61 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from 7af8c4882e07 to eda9ae15367e (2 revisions) (flutter/engine#55417) 2024-09-25 bdero@google.com [Flutter GPU] Add CullMode. (flutter/engine#55409) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 2e92f0b443f4 to 3541cdf2fae6 (1 revision) (flutter/engine#55412) 2024-09-24 jonahwilliams@google.com [Impeller] fix Impeller on windows. (flutter/engine#55323) 2024-09-24 jonahwilliams@google.com [Impeller] add basic culling checks during text frame dispatcher. (flutter/engine#55168) 2024-09-24 matanlurey@users.noreply.github.com Move each dart GN rule to a standalone file. (flutter/engine#55404) 2024-09-24 skia-flutter-autoroll@skia.org Roll Skia from 118914b760cb to 2e92f0b443f4 (1 revision) (flutter/engine#55406) 2024-09-24 jonahwilliams@google.com [Impeller] Pack impeller:Path into 2 vecs instead of 3. (flutter/engine#55028) 2024-09-24 codefu@google.com Disallow time traveling frame times (flutter/engine#55310) 2024-09-24 jason-simmons@users.noreply.github.com [Impeller] Delete command pools held by the CommandPoolRecyclerVK after decoding an image on the IO thread (flutter/engine#55398) 2024-09-24 skia-flutter-autoroll@skia.org Roll Skia from cf28f9dd411d to 118914b760cb (1 revision) (flutter/engine#55405) 2024-09-24 bdero@google.com [Flutter GPU] Add pipeline stencil config. (flutter/engine#55272) 2024-09-24 skia-flutter-autoroll@skia.org Roll Skia from 6e5ff9253147 to cf28f9dd411d (1 revision) (flutter/engine#55399) 2024-09-24 jonahwilliams@google.com [Impeller] delete expensive trace event. (flutter/engine#55400) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a golden that depends on #55270.
Resolves flutter/flutter#142731.
Allow setting the stencil compare function, pass/fail operations, and read/write masks.
Flutter GPU has light "shader object" style programs, so all of the stencil configuration state can be set on the
RenderPassat any time.New simple golden that exercises stencil ops:
