Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Sep 13, 2024

Improved legacy testing by validating a fullscreen and non fullscreen codepaths.

Added .git-blame-ignore-revs because git was failing to give blame values with that file missing. I dont think I added a global config anywhere but adding an empty file should not cause a problem.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@reidbaker reidbaker requested a review from a team September 13, 2024 20:31
…lscreen and non full screen window updates, use clear invocations to make test easier to read
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 16, 2024
@auto-submit auto-submit bot merged commit a8c9c31 into flutter:main Sep 16, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 16, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 16, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 16, 2024
flutter/engine@6b69813...04bc90b

2024-09-16 chinmaygarde@google.com [Embedder] Warn when embedders try to enable an unsupported renderer. (flutter/engine#55240)
2024-09-16 reidbaker@google.com flutter view add test 2 (flutter/engine#55188)
2024-09-16 skia-flutter-autoroll@skia.org Roll Skia from 87ba10cbfad3 to 68eeaa5e20dc (1 revision) (flutter/engine#55239)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants