This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Move zircon_tests from package:litetest to package:async_helper.
#55149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package:litetest to package:async_helper.zircon_tests from package:litetest to package:async_helper.
jason-simmons
approved these changes
Sep 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 13, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 13, 2024
flutter/engine@8609af6...4d5fea9 2024-09-12 matanlurey@users.noreply.github.com Remove all references to `litetest` from the engine repo. (flutter/engine#55163) 2024-09-12 skia-flutter-autoroll@skia.org Roll Dart SDK from aa27c61f5859 to 23fc7751b8b2 (1 revision) (flutter/engine#55160) 2024-09-12 skia-flutter-autoroll@skia.org Roll Skia from bcbc3038a8ad to 515a23f3cbe1 (2 revisions) (flutter/engine#55161) 2024-09-12 bdero@google.com Remove Impeller Scene � (flutter/engine#55118) 2024-09-12 skia-flutter-autoroll@skia.org Roll Skia from 26b048c6a53b to bcbc3038a8ad (3 revisions) (flutter/engine#55159) 2024-09-12 matanlurey@users.noreply.github.com Move `zircon_tests` from `package:litetest` to `package:async_helper`. (flutter/engine#55149) 2024-09-12 34871572+gmackall@users.noreply.github.com Add a note about re generating Gradle lockfiles (flutter/engine#55150) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The engine has historically used
package:litetest, a home grown invention that is a wrapper around the Dart SDK.In flutter/flutter#133569, we've moved over to the heavier weight
package:test, which has been simplified since first evaluated by the Dart SDK vending the dependencies we need. The last user ofpackage:litetestis a single test in the Fuchsia SDK,zircon_tests.This PR migrates the test from
litetest(which will be deleted) to the Dart SK vendoredasync_minittest. For this simple test case, there is only a 1-line behavioral change (notEquals(foo)becomes!= foo, true), and it allows us to remove dependencies from the tree.