This repository was archived by the owner on Feb 25, 2025. It is now read-only.
add back test itSendsTextShowPasswordToFrameworkOnAttach with new mock for display metrics #55110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k for display metrics
matanlurey
approved these changes
Sep 12, 2024
Contributor
|
auto label is removed for flutter/engine/55110, due to - The status or check suite Linux linux_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
Author
|
Merging over the mac unopt test because it is likely flutter/flutter#155110 |
Contributor
While I don't think we have any particular rule against - I would caution against doing this in the future. Let's escalate velocity issues with @jtmcdole and @johnmccutchan instead of "making our own velocity" by pushing on red. |
Contributor
Author
The tree has been too red this week to wait on green. |
Contributor
|
I agree - let's just make sure we're coupling actions like this with "here is an escalation that we can't do our jobs well and are being forced to make tradeoffs that are bad long-term". |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 13, 2024
… new mock for display metrics (flutter/engine#55110)
jtmcdole
reviewed
Sep 13, 2024
|
|
||
| Example: from engine/src/flutter on a Mac | ||
| `et build -c android_debug_unopt_arm64` | ||
| `testing/run_tests.py --android-variant=android_debug_unopt_arm64 --type=java --java-filter=io.flutter.embedding.android.FlutterViewTest` |
Member
There was a problem hiding this comment.
would be great to have an et test command for this.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 13, 2024
… new mock for display metrics (flutter/engine#55110)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 14, 2024
… new mock for display metrics (flutter/engine#55110)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 14, 2024
flutter/engine@ab9daaa...4d8d851 2024-09-14 34871572+gmackall@users.noreply.github.com Synthesize remove events on `PointerChange.ACTION_UP` and `PointerChange.ACTION_POINTER_UP` (flutter/engine#55157) 2024-09-13 skia-flutter-autoroll@skia.org Roll Skia from bdc5e73cb6c9 to 2b8e33aa4824 (1 revision) (flutter/engine#55192) 2024-09-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 302b6472b849 to c0f7e399ff4a (1 revision) (flutter/engine#55191) 2024-09-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[skwasm] Scene builder optimizations for platform view placement (#54949)" (flutter/engine#55193) 2024-09-13 flar@google.com Delete VolatilePathTracker in favor of Dispatch tracking (flutter/engine#55125) 2024-09-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 3YH1DEYJ-s93fHBw5... to -kKh_AYzPh_iEmTxK... (flutter/engine#55190) 2024-09-13 skia-flutter-autoroll@skia.org Roll Skia from 9877f459399a to bdc5e73cb6c9 (1 revision) (flutter/engine#55189) 2024-09-13 jonahwilliams@google.com [impeller] add Android flag for disabling surface control for debugging. (flutter/engine#55185) 2024-09-13 skia-flutter-autoroll@skia.org Roll Skia from a5a6d12b3642 to 9877f459399a (2 revisions) (flutter/engine#55187) 2024-09-13 skia-flutter-autoroll@skia.org Roll Dart SDK from eb664303c5ff to 302b6472b849 (2 revisions) (flutter/engine#55182) 2024-09-13 jacksongardner@google.com [skwasm] Scene builder optimizations for platform view placement (flutter/engine#54949) 2024-09-13 reidbaker@google.com add back test itSendsTextShowPasswordToFrameworkOnAttach with new mock for display metrics (flutter/engine#55110) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 3YH1DEYJ-s93 to -kKh_AYzPh_i If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1/5 for re adding tests documented in flutter/flutter/issues/154746
Pre-launch Checklist
///).