Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@robert-ancell
Copy link
Contributor

This means when rendering the correct layers are rendered for a view.

This means when rendering the correct layers are rendered for a view.
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

Looks great - I've got nothing!

@robert-ancell robert-ancell merged commit 0e646e8 into flutter:main Aug 27, 2024
@robert-ancell robert-ancell deleted the linux-render-view-id branch August 27, 2024 08:28
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 27, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 27, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 27, 2024
flutter/engine@b41ca79...7d751ac

2024-08-27 skia-flutter-autoroll@skia.org Roll Skia from 9460a3136627 to 7d9054c4317d (1 revision) (flutter/engine#54799)
2024-08-27 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from oGxqx29_HA1eEBnt9... to vIJGWtHj4Rdku9Ayv... (flutter/engine#54800)
2024-08-27 robert.ancell@canonical.com Store a set of layers per view. (flutter/engine#54793)
2024-08-27 skia-flutter-autoroll@skia.org Roll Skia from 56b353d1674a to 9460a3136627 (2 revisions) (flutter/engine#54798)
2024-08-27 49699333+dependabot[bot]@users.noreply.github.com Bump google/osv-scanner-action from 1.8.3 to 1.8.4 (flutter/engine#54797)
2024-08-27 skia-flutter-autoroll@skia.org Roll Skia from 78ebd463a911 to 56b353d1674a (1 revision) (flutter/engine#54795)
2024-08-27 robert.ancell@canonical.com Use TRUE/FALSE consistently for gboolean values. (flutter/engine#54768)
2024-08-27 skia-flutter-autoroll@skia.org Roll Skia from c9f157b2cc4c to 78ebd463a911 (1 revision) (flutter/engine#54792)
2024-08-26 skia-flutter-autoroll@skia.org Roll Skia from 50378c58b60c to c9f157b2cc4c (2 revisions) (flutter/engine#54790)
2024-08-26 flar@google.com Disable impeller cmake test until it is fixed (flutter/engine#54788)
2024-08-26 chris@bracken.jp macOS: Add @available check at macOS 12 workaround (flutter/engine#54784)
2024-08-26 skia-flutter-autoroll@skia.org Roll Skia from a05dbd2a60f0 to 50378c58b60c (7 revisions) (flutter/engine#54789)
2024-08-26 chris@bracken.jp macOS: Do not archive/upload FlutterMacOS.dSYM to cloud (flutter/engine#54787)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…54172)

flutter/engine@b41ca79...7d751ac

2024-08-27 skia-flutter-autoroll@skia.org Roll Skia from 9460a3136627 to 7d9054c4317d (1 revision) (flutter/engine#54799)
2024-08-27 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from oGxqx29_HA1eEBnt9... to vIJGWtHj4Rdku9Ayv... (flutter/engine#54800)
2024-08-27 robert.ancell@canonical.com Store a set of layers per view. (flutter/engine#54793)
2024-08-27 skia-flutter-autoroll@skia.org Roll Skia from 56b353d1674a to 9460a3136627 (2 revisions) (flutter/engine#54798)
2024-08-27 49699333+dependabot[bot]@users.noreply.github.com Bump google/osv-scanner-action from 1.8.3 to 1.8.4 (flutter/engine#54797)
2024-08-27 skia-flutter-autoroll@skia.org Roll Skia from 78ebd463a911 to 56b353d1674a (1 revision) (flutter/engine#54795)
2024-08-27 robert.ancell@canonical.com Use TRUE/FALSE consistently for gboolean values. (flutter/engine#54768)
2024-08-27 skia-flutter-autoroll@skia.org Roll Skia from c9f157b2cc4c to 78ebd463a911 (1 revision) (flutter/engine#54792)
2024-08-26 skia-flutter-autoroll@skia.org Roll Skia from 50378c58b60c to c9f157b2cc4c (2 revisions) (flutter/engine#54790)
2024-08-26 flar@google.com Disable impeller cmake test until it is fixed (flutter/engine#54788)
2024-08-26 chris@bracken.jp macOS: Add @available check at macOS 12 workaround (flutter/engine#54784)
2024-08-26 skia-flutter-autoroll@skia.org Roll Skia from a05dbd2a60f0 to 50378c58b60c (7 revisions) (flutter/engine#54789)
2024-08-26 chris@bracken.jp macOS: Do not archive/upload FlutterMacOS.dSYM to cloud (flutter/engine#54787)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants