This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Remove unused ColorHSB. #54659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't realize I hadn't cleaned this up. We've never needed it in Impeller.
Contributor
|
auto label is removed for flutter/engine/54659, due to - The status or check suite Linux local_engine_builds has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
auto label is removed for flutter/engine/54659, due to - The status or check suite Linux local_engine_builds has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 21, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 21, 2024
flutter/engine@b1220aa...b94e009 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from a3388794e06e to d576296091e0 (1 revision) (flutter/engine#54670) 2024-08-21 jason-simmons@users.noreply.github.com Remove unnecessary breaks in default clauses of switch statements (flutter/engine#54669) 2024-08-21 chinmaygarde@google.com [Impeller] Remove unused ColorHSB. (flutter/engine#54659) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…3817) flutter/engine@b1220aa...b94e009 2024-08-21 skia-flutter-autoroll@skia.org Roll Skia from a3388794e06e to d576296091e0 (1 revision) (flutter/engine#54670) 2024-08-21 jason-simmons@users.noreply.github.com Remove unnecessary breaks in default clauses of switch statements (flutter/engine#54669) 2024-08-21 chinmaygarde@google.com [Impeller] Remove unused ColorHSB. (flutter/engine#54659) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't realize I hadn't cleaned this up. We've never needed it in Impeller.