Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@tvolkert
Copy link
Contributor

Added docs to FrameCallback and FrameData

@tvolkert tvolkert requested a review from jonahwilliams August 13, 2024 05:14

/// Signature for [PlatformDispatcher.onBeginFrame].
///
/// The `duration` argument is the point at which the current frame interval
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chinmay is out right now. is this blocking?

@tvolkert tvolkert merged commit 0559695 into flutter:main Oct 2, 2024
@tvolkert tvolkert deleted the docs branch October 2, 2024 05:08
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 2, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 2, 2024
flutter/engine@e0f049d...0559695

2024-10-02 tvolkert@users.noreply.github.com Added Dart docs (flutter/engine#54506)
2024-10-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 691701c26cfd to b4b806ab97f2 (1 revision) (flutter/engine#55578)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Dec 18, 2024
Added docs to `FrameCallback` and `FrameData`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants