This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Roll Dart SDK from 35bc5c866149 to cb89f7cad79c (1 revision) (#54474)" #54487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lutter#54474)" This reverts commit 7a55e11. https://dart.googlesource.com/sdk/+/1b1740e941c33d64ed1bbca4914d0e6ad6b22cbb is causing a regression when compiling Wasm with --extra-compiler-option=--no-source-maps
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
matanlurey
approved these changes
Aug 10, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 10, 2024
flutter/engine@2f577d8...3acd373 2024-08-10 jason-simmons@users.noreply.github.com Revert "Roll Dart SDK from 35bc5c866149 to cb89f7cad79c (1 revision) (#54474)" (flutter/engine#54487) 2024-08-09 chinmaygarde@google.com Remove shared mutex from FML and use the C++17 variants. (flutter/engine#54482) 2024-08-09 skia-flutter-autoroll@skia.org Roll Skia from 2a7e7567607e to eeffce72693c (1 revision) (flutter/engine#54480) 2024-08-09 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from ra4HZdsFPpgZgDON6... to q3WfgLnPmQ-1lBu8M... (flutter/engine#54479) 2024-08-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 35bc5c866149 to cb89f7cad79c (1 revision) (flutter/engine#54474) 2024-08-09 skia-flutter-autoroll@skia.org Roll Skia from 5e190559fefd to 2a7e7567607e (1 revision) (flutter/engine#54477) 2024-08-09 chinmaygarde@google.com Remove fml::size. (flutter/engine#54476) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 12, 2024
…e maps on --no-source-maps as well as --extra-compiler-option=--no-source-maps When `flutter build web --wasm` run passed `--extra-compiler-option=--no-source-maps` it caused the compiler not to generate source maps, but `dart compile wasm` thought it does and tried and use the file, which causses an issue. We can remove this workaround once this CL rolls up to flutter and we change `--extra-compiler-option=--no-source-maps` to `--no-source-maps`. Bug: flutter/engine#54487 Change-Id: I82c56ab7d1bc09e53919a6b72b0b1771215d8d25 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380000 Reviewed-by: Ömer Ağacan <omersa@google.com> Commit-Queue: Martin Kustermann <kustermann@google.com>
DBowen33
pushed a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
…3210) flutter/engine@2f577d8...3acd373 2024-08-10 jason-simmons@users.noreply.github.com Revert "Roll Dart SDK from 35bc5c866149 to cb89f7cad79c (1 revision) (flutter#54474)" (flutter/engine#54487) 2024-08-09 chinmaygarde@google.com Remove shared mutex from FML and use the C++17 variants. (flutter/engine#54482) 2024-08-09 skia-flutter-autoroll@skia.org Roll Skia from 2a7e7567607e to eeffce72693c (1 revision) (flutter/engine#54480) 2024-08-09 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from ra4HZdsFPpgZgDON6... to q3WfgLnPmQ-1lBu8M... (flutter/engine#54479) 2024-08-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 35bc5c866149 to cb89f7cad79c (1 revision) (flutter/engine#54474) 2024-08-09 skia-flutter-autoroll@skia.org Roll Skia from 5e190559fefd to 2a7e7567607e (1 revision) (flutter/engine#54477) 2024-08-09 chinmaygarde@google.com Remove fml::size. (flutter/engine#54476) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…3210) flutter/engine@2f577d8...3acd373 2024-08-10 jason-simmons@users.noreply.github.com Revert "Roll Dart SDK from 35bc5c866149 to cb89f7cad79c (1 revision) (flutter#54474)" (flutter/engine#54487) 2024-08-09 chinmaygarde@google.com Remove shared mutex from FML and use the C++17 variants. (flutter/engine#54482) 2024-08-09 skia-flutter-autoroll@skia.org Roll Skia from 2a7e7567607e to eeffce72693c (1 revision) (flutter/engine#54480) 2024-08-09 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from ra4HZdsFPpgZgDON6... to q3WfgLnPmQ-1lBu8M... (flutter/engine#54479) 2024-08-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 35bc5c866149 to cb89f7cad79c (1 revision) (flutter/engine#54474) 2024-08-09 skia-flutter-autoroll@skia.org Roll Skia from 5e190559fefd to 2a7e7567607e (1 revision) (flutter/engine#54477) 2024-08-09 chinmaygarde@google.com Remove fml::size. (flutter/engine#54476) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7a55e11.
https://dart.googlesource.com/sdk/+/1b1740e941c33d64ed1bbca4914d0e6ad6b22cbb is causing a regression when compiling Wasm with --extra-compiler-option=--no-source-maps