This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[canvaskit] Detect animated WebP images #54418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
reviewed
Aug 8, 2024
| /// Reads the header of a WebP file to determine if it is animated or not. | ||
| /// | ||
| /// See https://developers.google.com/speed/webp/docs/riff_container | ||
| class WebpHeaderReader { |
Contributor
There was a problem hiding this comment.
Nit: I kinda like when these types of things are private, in their own library and just the functional thing as a top-level function bool isAnimated(bytes). With the class as private. One should only call isAnimated once, right?
Contributor
Author
There was a problem hiding this comment.
Done. isAnimated isn't even exposed outside the file. It's an implementation detail of detectImageType
kevmoo
reviewed
Aug 8, 2024
| ImageType? expectedImageType; | ||
| final String testFileExtension = | ||
| testFile.substring(testFile.lastIndexOf('.') + 1); | ||
| switch (testFileExtension) { |
Contributor
There was a problem hiding this comment.
might could use switch expression here?
Contributor
Author
There was a problem hiding this comment.
Nice! Didn't know about this in the language
kevmoo
approved these changes
Aug 8, 2024
kevmoo
reviewed
Aug 8, 2024
| 'avif' => ImageType.avif, | ||
| 'bmp' => ImageType.bmp, | ||
| 'png' => ImageType.png, | ||
| String() => null, |
Contributor
There was a problem hiding this comment.
or
Suggested change
| String() => null, | |
| _ => null, |
🤷
kevmoo
reviewed
Aug 8, 2024
Comment on lines
39
to
41
| final _WebpHeaderReader webpHeaderReader = | ||
| _WebpHeaderReader(data.buffer.asByteData()); | ||
| if (webpHeaderReader.isAnimated()) { |
Contributor
There was a problem hiding this comment.
Suggested change
| final _WebpHeaderReader webpHeaderReader = | |
| _WebpHeaderReader(data.buffer.asByteData()); | |
| if (webpHeaderReader.isAnimated()) { | |
| if (_WebpHeaderReader(data.buffer.asByteData()).isAnimated()) { |
compromise?
Contributor
There was a problem hiding this comment.
meh...not a biggy. I'm being picky
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 8, 2024
flutter/engine@ef820aa...0520889 2024-08-08 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Detect animated WebP images (flutter/engine#54418) 2024-08-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 067c7cfcbc8c to ff0404c72fc5 (1 revision) (flutter/engine#54455) 2024-08-08 jonahwilliams@google.com [Impeller] move aiks text tests to DL. (flutter/engine#54293) 2024-08-08 skia-flutter-autoroll@skia.org Roll Skia from 0c6dd1e6ff8e to 4cff580721cf (20 revisions) (flutter/engine#54454) 2024-08-08 robert.ancell@canonical.com Add a precision to the fragment shader (flutter/engine#54109) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mdebbar
reviewed
Aug 9, 2024
Contributor
mdebbar
left a comment
There was a problem hiding this comment.
Sorry for the late review, but this LGTM too!
| bool _readWebpHeader() { | ||
| final String riffBytes = _readFourCC(); | ||
|
|
||
| // Read file size byte. |
Contributor
There was a problem hiding this comment.
get out of here with your snark! 😜
DBowen33
pushed a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
…3132) flutter/engine@ef820aa...0520889 2024-08-08 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Detect animated WebP images (flutter/engine#54418) 2024-08-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 067c7cfcbc8c to ff0404c72fc5 (1 revision) (flutter/engine#54455) 2024-08-08 jonahwilliams@google.com [Impeller] move aiks text tests to DL. (flutter/engine#54293) 2024-08-08 skia-flutter-autoroll@skia.org Roll Skia from 0c6dd1e6ff8e to 4cff580721cf (20 revisions) (flutter/engine#54454) 2024-08-08 robert.ancell@canonical.com Add a precision to the fragment shader (flutter/engine#54109) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…3132) flutter/engine@ef820aa...0520889 2024-08-08 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Detect animated WebP images (flutter/engine#54418) 2024-08-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 067c7cfcbc8c to ff0404c72fc5 (1 revision) (flutter/engine#54455) 2024-08-08 jonahwilliams@google.com [Impeller] move aiks text tests to DL. (flutter/engine#54293) 2024-08-08 skia-flutter-autoroll@skia.org Roll Skia from 0c6dd1e6ff8e to 4cff580721cf (20 revisions) (flutter/engine#54454) 2024-08-08 robert.ancell@canonical.com Add a precision to the fragment shader (flutter/engine#54109) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reads the WebP header to determine if the WebP image is animated or not. If it's not animated, we can use
<img>tag decoding for less jank.The WebP half of flutter/flutter#151911
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.