This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] move more aiks tests to DL. #54260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
commented
Jul 31, 2024
| ASSERT_TRUE(OpenPlaygroundHere(builder.Build())); | ||
| } | ||
|
|
||
| TEST_P(AiksTest, DrawPaintTransformsBounds) { |
Contributor
Author
There was a problem hiding this comment.
Something went wrong with this one.
Contributor
There was a problem hiding this comment.
I can't spot any differences... :(
Contributor
There was a problem hiding this comment.
I see the file "gradient.frag.iplr" in 2 different places in the out/.../gen directory.
../out/host_debug_unopt_arm64/gen/flutter/impeller/fixtures/gradient.frag.iplr
../out/host_debug_unopt_arm64/gen/flutter/impeller/fixtures/assets/gradient.frag.iplr
Contributor
There was a problem hiding this comment.
But I only see one gradient.frag in the git tree so they should have both been generated from the same source...
Contributor
There was a problem hiding this comment.
And their contents are identical...
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
flar
approved these changes
Jul 31, 2024
Contributor
flar
left a comment
There was a problem hiding this comment.
LGTM once you find the source of what went wrong with the second test...
|
|
||
| auto runtime_stage = runtime_stages[PlaygroundBackendToRuntimeStageBackend( | ||
| test->GetBackend())]; | ||
|
|
Contributor
There was a problem hiding this comment.
Is it worth copying over the asserts from the original code?
| ASSERT_TRUE(OpenPlaygroundHere(builder.Build())); | ||
| } | ||
|
|
||
| TEST_P(AiksTest, DrawPaintTransformsBounds) { |
Contributor
There was a problem hiding this comment.
I can't spot any differences... :(
jonahwilliams
commented
Jul 31, 2024
| const std::shared_ptr<std::vector<uint8_t>>& uniform_data = {}, | ||
| const std::vector<std::shared_ptr<DlColorSource>>& samplers = {}) { | ||
| auto runtime_stages = | ||
| test->OpenAssetAsRuntimeStage("runtime_stage_example.frag.iplr"); |
|
Golden file changes are available for triage from new commit, Click here to view. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 1, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 1, 2024
flutter/engine@0fbff21...f546fef 2024-08-01 skia-flutter-autoroll@skia.org Roll Dart SDK from efabc9163078 to 0b09d933cd1e (1 revision) (flutter/engine#54270) 2024-08-01 jonahwilliams@google.com [Impeller] move more aiks tests to DL. (flutter/engine#54260) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…2661) flutter/engine@0fbff21...f546fef 2024-08-01 skia-flutter-autoroll@skia.org Roll Dart SDK from efabc9163078 to 0b09d933cd1e (1 revision) (flutter/engine#54270) 2024-08-01 jonahwilliams@google.com [Impeller] move more aiks tests to DL. (flutter/engine#54260) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…2661) flutter/engine@0fbff21...f546fef 2024-08-01 skia-flutter-autoroll@skia.org Roll Dart SDK from efabc9163078 to 0b09d933cd1e (1 revision) (flutter/engine#54270) 2024-08-01 jonahwilliams@google.com [Impeller] move more aiks tests to DL. (flutter/engine#54260) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#142054