This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[DisplayList] track unbounded state on save layers and DisplayLists #54032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
approved these changes
Jul 23, 2024
Contributor
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
You could use this setting to update the following line in impeller for this PR:
https://github.com/flutter/engine/blob/main/impeller/display_list/dl_dispatcher.cc#L629-L633
Contributor
Author
Since I made some minor tweaks to DL logic that could potentially impact Flutter (mainly the new handling of unbounded child DrawDisplayList calls), I'll plan to land this support and then the change to impeller separately. |
Contributor
|
SGTM |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 24, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 24, 2024
flutter/engine@f5ec4ab...1572635 2024-07-24 58529443+srujzs@users.noreply.github.com Change JSArray.length to return int (flutter/engine#54051) 2024-07-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 17131486a2f7 to e53beb039093 (1 revision) (flutter/engine#54066) 2024-07-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ZcBsXDojTYbriHD7_... to qA7S-DZ5FyMtcM7_J... (flutter/engine#54064) 2024-07-24 flar@google.com [DisplayList] Fix assertions on DisplayList verbose comparison tests (flutter/engine#54065) 2024-07-24 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from 5bzzKaW7fCp_No_w_... to clqtZA8cx4GEXwcOe... (flutter/engine#54063) 2024-07-23 chris@bracken.jp [iOS] Flush layer pool after platform view dispose (flutter/engine#54056) 2024-07-23 chris@bracken.jp [iOS] Mark EmbeddedViewCount const (flutter/engine#54062) 2024-07-23 skia-flutter-autoroll@skia.org Roll Skia from f4355cf73508 to 3f1b4e98f65a (1 revision) (flutter/engine#54060) 2024-07-23 skia-flutter-autoroll@skia.org Roll Skia from 2d518b6a793a to f4355cf73508 (9 revisions) (flutter/engine#54058) 2024-07-23 skia-flutter-autoroll@skia.org Roll Dart SDK from eeb2e4e409bf to 17131486a2f7 (1 revision) (flutter/engine#54055) 2024-07-23 skia-flutter-autoroll@skia.org Roll Skia from a9019fddac28 to 2d518b6a793a (4 revisions) (flutter/engine#54052) 2024-07-23 jonahwilliams@google.com [Impeller] add emulated advanced blend support for exp canvas. (flutter/engine#54020) 2024-07-23 skia-flutter-autoroll@skia.org Roll Skia from 1cda2a7b0ee4 to a9019fddac28 (3 revisions) (flutter/engine#54050) 2024-07-23 flar@google.com [DisplayList] track unbounded state on save layers and DisplayLists (flutter/engine#54032) 2024-07-23 robert.ancell@canonical.com Temporarily disable use of glBlitFramebuffer on NVIDIA (flutter/engine#54040) 2024-07-23 robert.ancell@canonical.com Set the view ID for FlView (flutter/engine#54043) 2024-07-23 chinmaygarde@google.com [Impeller] Implement OpenGL to Vulkan texture trampolining. (flutter/engine#53966) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from ZcBsXDojTYbr to qA7S-DZ5FyMt If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Contributor
|
We need to open up a CP request for 3.24 and it will get picked up after. |
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…52203) flutter/engine@f5ec4ab...1572635 2024-07-24 58529443+srujzs@users.noreply.github.com Change JSArray.length to return int (flutter/engine#54051) 2024-07-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 17131486a2f7 to e53beb039093 (1 revision) (flutter/engine#54066) 2024-07-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ZcBsXDojTYbriHD7_... to qA7S-DZ5FyMtcM7_J... (flutter/engine#54064) 2024-07-24 flar@google.com [DisplayList] Fix assertions on DisplayList verbose comparison tests (flutter/engine#54065) 2024-07-24 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from 5bzzKaW7fCp_No_w_... to clqtZA8cx4GEXwcOe... (flutter/engine#54063) 2024-07-23 chris@bracken.jp [iOS] Flush layer pool after platform view dispose (flutter/engine#54056) 2024-07-23 chris@bracken.jp [iOS] Mark EmbeddedViewCount const (flutter/engine#54062) 2024-07-23 skia-flutter-autoroll@skia.org Roll Skia from f4355cf73508 to 3f1b4e98f65a (1 revision) (flutter/engine#54060) 2024-07-23 skia-flutter-autoroll@skia.org Roll Skia from 2d518b6a793a to f4355cf73508 (9 revisions) (flutter/engine#54058) 2024-07-23 skia-flutter-autoroll@skia.org Roll Dart SDK from eeb2e4e409bf to 17131486a2f7 (1 revision) (flutter/engine#54055) 2024-07-23 skia-flutter-autoroll@skia.org Roll Skia from a9019fddac28 to 2d518b6a793a (4 revisions) (flutter/engine#54052) 2024-07-23 jonahwilliams@google.com [Impeller] add emulated advanced blend support for exp canvas. (flutter/engine#54020) 2024-07-23 skia-flutter-autoroll@skia.org Roll Skia from 1cda2a7b0ee4 to a9019fddac28 (3 revisions) (flutter/engine#54050) 2024-07-23 flar@google.com [DisplayList] track unbounded state on save layers and DisplayLists (flutter/engine#54032) 2024-07-23 robert.ancell@canonical.com Temporarily disable use of glBlitFramebuffer on NVIDIA (flutter/engine#54040) 2024-07-23 robert.ancell@canonical.com Set the view ID for FlView (flutter/engine#54043) 2024-07-23 chinmaygarde@google.com [Impeller] Implement OpenGL to Vulkan texture trampolining. (flutter/engine#53966) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from ZcBsXDojTYbr to qA7S-DZ5FyMt If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…52203) flutter/engine@f5ec4ab...1572635 2024-07-24 58529443+srujzs@users.noreply.github.com Change JSArray.length to return int (flutter/engine#54051) 2024-07-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 17131486a2f7 to e53beb039093 (1 revision) (flutter/engine#54066) 2024-07-24 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ZcBsXDojTYbriHD7_... to qA7S-DZ5FyMtcM7_J... (flutter/engine#54064) 2024-07-24 flar@google.com [DisplayList] Fix assertions on DisplayList verbose comparison tests (flutter/engine#54065) 2024-07-24 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from 5bzzKaW7fCp_No_w_... to clqtZA8cx4GEXwcOe... (flutter/engine#54063) 2024-07-23 chris@bracken.jp [iOS] Flush layer pool after platform view dispose (flutter/engine#54056) 2024-07-23 chris@bracken.jp [iOS] Mark EmbeddedViewCount const (flutter/engine#54062) 2024-07-23 skia-flutter-autoroll@skia.org Roll Skia from f4355cf73508 to 3f1b4e98f65a (1 revision) (flutter/engine#54060) 2024-07-23 skia-flutter-autoroll@skia.org Roll Skia from 2d518b6a793a to f4355cf73508 (9 revisions) (flutter/engine#54058) 2024-07-23 skia-flutter-autoroll@skia.org Roll Dart SDK from eeb2e4e409bf to 17131486a2f7 (1 revision) (flutter/engine#54055) 2024-07-23 skia-flutter-autoroll@skia.org Roll Skia from a9019fddac28 to 2d518b6a793a (4 revisions) (flutter/engine#54052) 2024-07-23 jonahwilliams@google.com [Impeller] add emulated advanced blend support for exp canvas. (flutter/engine#54020) 2024-07-23 skia-flutter-autoroll@skia.org Roll Skia from 1cda2a7b0ee4 to a9019fddac28 (3 revisions) (flutter/engine#54050) 2024-07-23 flar@google.com [DisplayList] track unbounded state on save layers and DisplayLists (flutter/engine#54032) 2024-07-23 robert.ancell@canonical.com Temporarily disable use of glBlitFramebuffer on NVIDIA (flutter/engine#54040) 2024-07-23 robert.ancell@canonical.com Set the view ID for FlView (flutter/engine#54043) 2024-07-23 chinmaygarde@google.com [Impeller] Implement OpenGL to Vulkan texture trampolining. (flutter/engine#53966) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from ZcBsXDojTYbr to qA7S-DZ5FyMt If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New flags on SaveLayerOptions will report if a saveLayer result is unbounded because a rendering operation within its contents did not have a definable bounds and there was no clip installed at the time (consider DrawPaint for example). A similar flag is found on DisplayList objects which reports if their top level had an unbounded operation.