This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Move images to flutter/assets-for-api-docs #53917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
You can see that this works in github by previewing the actual files: https://github.com/flutter/engine/blob/dcf9bd36cb051df0250a601a74464df40419db69/impeller/README.md |
Contributor
|
Local tools like Obsidian break if you don't use the RAW URL. I think GitHub may be doing the conversions automagically. But, it works if I change the asset URL to use https://raw.githubusercontent.com/flutter/assets-for-api-docs/5da33067f5cfc7f177d9c460d618397aad9082ca/assets/engine/impeller/android_profiling/image.avif Before: After: 
|
Contributor
|
Does viewing on GitHub break if you directly reference the images from raw.githubusercontent.com? |
Member
Author
|
will try it out |
Member
Author
27MB of images should not be in the source tree. Caveat: If you use VSCode's markdown preview, it does not support images outside the workspace. One solution to this would be to submodule the assets back into the assets folder. Fixes flutter/flutter#151691
chinmaygarde
approved these changes
Jul 15, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 16, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 16, 2024
flutter/engine@f1363fb...235e67f 2024-07-16 skia-flutter-autoroll@skia.org Roll Skia from d4acfbe0b001 to c91cad775529 (1 revision) (flutter/engine#53924) 2024-07-16 34871572+gmackall@users.noreply.github.com Align `tools/android_sdk/packages.txt` with what is uploaded to CIPD (flutter/engine#53921) 2024-07-15 skia-flutter-autoroll@skia.org Roll Skia from 6347d8255f83 to d4acfbe0b001 (3 revisions) (flutter/engine#53919) 2024-07-15 codefu@google.com Move images to flutter/assets-for-api-docs (flutter/engine#53917) 2024-07-15 skia-flutter-autoroll@skia.org Roll Skia from b63d0290b826 to 6347d8255f83 (5 revisions) (flutter/engine#53916) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…1802) flutter/engine@f1363fb...235e67f 2024-07-16 skia-flutter-autoroll@skia.org Roll Skia from d4acfbe0b001 to c91cad775529 (1 revision) (flutter/engine#53924) 2024-07-16 34871572+gmackall@users.noreply.github.com Align `tools/android_sdk/packages.txt` with what is uploaded to CIPD (flutter/engine#53921) 2024-07-15 skia-flutter-autoroll@skia.org Roll Skia from 6347d8255f83 to d4acfbe0b001 (3 revisions) (flutter/engine#53919) 2024-07-15 codefu@google.com Move images to flutter/assets-for-api-docs (flutter/engine#53917) 2024-07-15 skia-flutter-autoroll@skia.org Roll Skia from b63d0290b826 to 6347d8255f83 (5 revisions) (flutter/engine#53916) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
27MB of images should not be in the source tree.
Caveat: If you use VSCode's markdown preview, it does not support images outside the workspace. One solution to this would be to submodule the assets back into the assets folder - however that would break github rendering of images.
Fixes flutter/flutter#151691