This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Reland Use Skia software renderer to draw stroked text. #53238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
May 31, 2024 20:06
Contributor
Author
|
Created a merge conflict with myself. |
chinmaygarde
approved these changes
Jun 6, 2024
Contributor
chinmaygarde
left a comment
There was a problem hiding this comment.
I dont understand the updates. Just a conflict?
Contributor
Author
|
This PR changed the signature of impeller::MakeTextFrameFromTextBlobSkia, but #53229 added a new usage of that API |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 6, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 6, 2024
flutter/engine@0edca2e...32c3b9b 2024-06-06 yjbanov@google.com [web] clean up dynamic calls, remove always_specify_types (flutter/engine#53228) 2024-06-06 jonahwilliams@google.com [Impeller] Reland Use Skia software renderer to draw stroked text. (flutter/engine#53238) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to match the rounding of glyphs to fix flutter/flutter#138670 . We also don't have sufficient AA quality with 4x MSAA for high quality strokes.
Fixes flutter/flutter#138670
Fixes flutter/flutter#136688