This repository was archived by the owner on Feb 25, 2025. It is now read-only.
java fail on format missing #53176
Merged
java fail on format missing #53176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ci/bin/format.dart
Outdated
| return true; | ||
| } | ||
| return applyPatch(failures); | ||
| if (failures.first == _javaFormatErrorString) { |
Contributor
There was a problem hiding this comment.
Can we tighten this a bit:
failures.length == 1 && failures.first == _javaFormatErrorString
Contributor
Author
There was a problem hiding this comment.
Done, FWIW if we in the future return more strings the patch will fail to apply but that is probably a better error condition than swallowing the patch info.
johnmccutchan
approved these changes
Jun 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 4, 2024
flutter/engine@fe00f02...3dd4015 2024-06-04 jonahwilliams@google.com [Impeller] tighten fast gradient condition. (flutter/engine#53195) 2024-06-04 reidbaker@google.com java fail on format missing (flutter/engine#53176) 2024-06-04 emmanuelferdman@gmail.com [web] update version-lock file location (flutter/engine#52842) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Cause java format to fail when java binary is not found. flutter#149604