This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Short-circuit crawling all targets in et {build|test|query}
#52832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnmccutchan
approved these changes
May 15, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 15, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 15, 2024
flutter/engine@41b86b5...cd15098 2024-05-15 skia-flutter-autoroll@skia.org Roll Skia from b9a304eb05d2 to 0f737206b709 (3 revisions) (flutter/engine#52858) 2024-05-15 matanlurey@users.noreply.github.com Short-circuit crawling all targets in `et {build|test|query}` (flutter/engine#52832) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced May 15, 2024
Closed
auto-submit bot
pushed a commit
that referenced
this pull request
May 16, 2024
…y}` (#52866) Closes flutter/flutter#148442. This restores functionality that existed prior in #52832: - Splits `runGn` to `ensureBuildDir`, which is in practice what it does.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes flutter/flutter#147666.
This is a large change, I'd be happy to either review synchronously or change commands one at a time, but I think this is overall the right approach. I also didn't see any reason to reuse the
BuildRunnercode for these commands, the flow is basically:graph LR A[et targetsOrPatterns] --> B[gn desc --format=json] B --> C[existing code that runs ninja/workers]Quick summary of changes:
LabelandTargetPatterntype to avoid awkward string parsing/manipulation all overgn_utils(i.e.targetsFromCommandLineand friends) with an invocation ofgn descHere is the fun part, results (and some manual integration tests):
In other words, ~5x improvement on
et buildandet queryis much faster as well.