This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] route fuchsia.sysmem2.Allocator pt 2 #52509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cl/629919249 per go/flutter-fuchsia-pr-policy |
08d0d52 to
50e8c8a
Compare
jrwang
approved these changes
May 2, 2024
Contributor
jrwang
left a comment
There was a problem hiding this comment.
LGTM (assuming google3 presubmit errors are unrelated)
chinmaygarde
approved these changes
May 2, 2024
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed. flutter/flutter#146858
50e8c8a to
4ac1668
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 3, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 3, 2024
flutter/engine@98a800b...d8c8cf4 2024-05-03 dustingreen@google.com [fuchsia] route fuchsia.sysmem2.Allocator pt 2 (flutter/engine#52509) 2024-05-03 jason-simmons@users.noreply.github.com [et] Add Linux host_debug_unopt local engine builder (flutter/engine#52538) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed.
fixes flutter/flutter#146858
///).