-
Notifications
You must be signed in to change notification settings - Fork 6k
[Impeller] Document the EGL toolkit. #52469
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jonahwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
flutter/engine@0ce6771...0014e03 2024-05-01 john@johnmccutchan.com Fix et run (flutter/engine#52477) 2024-05-01 skia-flutter-autoroll@skia.org Roll Skia from 5f4ebd628994 to bfbd738fb97b (2 revisions) (flutter/engine#52479) 2024-05-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from HP2saK9sVOtKvpquC... to PIHl-e41i3mzbriG1... (flutter/engine#52480) 2024-05-01 skia-flutter-autoroll@skia.org Roll Skia from a6bc04f984d2 to 5f4ebd628994 (1 revision) (flutter/engine#52478) 2024-05-01 skia-flutter-autoroll@skia.org Roll Dart SDK from c88854d4282c to d946408c559a (1 revision) (flutter/engine#52476) 2024-05-01 chinmaygarde@google.com [Impeller] Document the EGL toolkit. (flutter/engine#52469) 2024-05-01 jacksongardner@google.com [skwasm] Change default `FilterQuality` to `None` for image shaders. (flutter/engine#52468) 2024-05-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 3f649c97a08c to c88854d4282c (1 revision) (flutter/engine#52475) 2024-04-30 skia-flutter-autoroll@skia.org Roll Skia from 30aaaef0390d to a6bc04f984d2 (1 revision) (flutter/engine#52471) 2024-04-30 skia-flutter-autoroll@skia.org Roll Skia from 85ec65ecd5ec to 30aaaef0390d (4 revisions) (flutter/engine#52466) 2024-04-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 7a517de88964 to 3f649c97a08c (1 revision) (flutter/engine#52465) 2024-04-30 skia-flutter-autoroll@skia.org Roll Skia from 77350e051f71 to 85ec65ecd5ec (2 revisions) (flutter/engine#52464) 2024-04-30 skia-flutter-autoroll@skia.org Roll Skia from 8f2d039e1190 to 77350e051f71 (1 revision) (flutter/engine#52460) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from HP2saK9sVOtK to PIHl-e41i3mz If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
No change in functionality. Just adds docs.