[Impeller] Cleanup PipelineVK::Create
#52278
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
Seems like a reasonable change. That said, have you done any experiments to confirm that batch submissions will be faster? I'd build something quick and dirty first and measure it single core performance.
If its not any better we should abandon this line of work before we spend more time on it.
I don't think there is a shortcut here unfortunately. If you are eager to know if it helps I think it's plausible we get some profiles sometime monday barring any surprises. This PR was obligatory since I need to generate multiple |
flutter/engine@066953b...f23cc4d 2024-04-23 30870216+gaaclarke@users.noreply.github.com [Impeller] Cleanup `PipelineVK::Create` (flutter/engine#52278) 2024-04-23 johnoneil@users.noreply.github.com Issue #146080 : Fix for incorrect STB based atlas glyph scaling (flutter/engine#51882) 2024-04-23 jason-simmons@users.noreply.github.com [Impeller] Do not call std::forward on the serialized arguments in the canvas recorder (flutter/engine#52307) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
PipelineVK::Createwas one giant function. Now its 3 smaller functions and one less giant but still big function.This is groundwork for trying to batch calls.
I tried to split out the creation of the
vk::GraphicsPipelineCreateInfobut it holds pointers to things on the stack so it's hard to do.test exempt: refactor, no new functionality
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.