Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jrwang
Copy link
Contributor

@jrwang jrwang commented Apr 19, 2024

Update Fuchsia API version to 17

b/328121174

Changes are tested on device and in google3 in cl/626319415.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jrwang jrwang closed this Apr 19, 2024
@jrwang jrwang reopened this Apr 19, 2024
@jrwang jrwang marked this pull request as draft April 19, 2024 18:58
@jrwang jrwang marked this pull request as ready for review April 19, 2024 19:01
@jrwang jrwang merged commit 79f4995 into flutter:main Apr 23, 2024
@jrwang jrwang deleted the fuchsia_api_version_17 branch April 23, 2024 12:38
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 23, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 23, 2024
flutter/engine@ffd3911...79f4995

2024-04-23 jonnywang@google.com [fuchsia] Update Fuchsia API version to 17 (flutter/engine#52266)
2024-04-23 kjlubick@users.noreply.github.com [skia] Remove no-op GN flag (flutter/engine#52121)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants