Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@brianquinlan
Copy link
Contributor

@brianquinlan brianquinlan commented Apr 18, 2024

package:web_socket is used by newer versions package:web_socket_channel.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@brianquinlan brianquinlan changed the title Add a dependency on package:web_socket Add a dependency on package:web_socket in pkg_demo_test Apr 18, 2024
@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 19, 2024
@auto-submit auto-submit bot merged commit 67a8155 into flutter:main Apr 19, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 19, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 19, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 19, 2024
flutter/engine@ff47188...b6234dd

2024-04-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 62b85ea79bce to a46161eec56d (1 revision) (flutter/engine#52243)
2024-04-19 bquinlan@google.com Add a dependency on `package:web_socket` in pkg_demo_test (flutter/engine#52239)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
…7029)

flutter/engine@ff47188...b6234dd

2024-04-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 62b85ea79bce to a46161eec56d (1 revision) (flutter/engine#52243)
2024-04-19 bquinlan@google.com Add a dependency on `package:web_socket` in pkg_demo_test (flutter/engine#52239)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants