Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Apr 10, 2024

This also disables goma in both pre- and post-submit for mac builds.

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso merged commit 7cbb90f into flutter:main Apr 10, 2024
@zanderso zanderso deleted the mac-postsubmit-overrides branch April 10, 2024 16:25
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 10, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 10, 2024
zanderso pushed a commit to flutter/flutter that referenced this pull request Apr 10, 2024
flutter/engine@077b742...beee02b

2024-04-10 skia-flutter-autoroll@skia.org Roll Dart SDK from
78174b41ab0f to 393a24d37b39 (8 revisions) (flutter/engine#52020)
2024-04-10 zanderso@users.noreply.github.com Use RBE in mac builds in
presubmit but not postsubmit (flutter/engine#52018)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
…6591)

flutter/engine@077b742...beee02b

2024-04-10 skia-flutter-autoroll@skia.org Roll Dart SDK from
78174b41ab0f to 393a24d37b39 (8 revisions) (flutter/engine#52020)
2024-04-10 zanderso@users.noreply.github.com Use RBE in mac builds in
presubmit but not postsubmit (flutter/engine#52018)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants