This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] NumberNear implements precision-based comparisons #52001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Once I came up with what seems like reasonable criteria for the precision of the compares, I had to change just a handful of the tests that were using inaccurate numbers. The matrix tests were obviously truncating @bdero ? |
Logharaa
reviewed
Apr 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 10, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 10, 2024
flutter/engine@cee489a...0d5412d 2024-04-10 skia-flutter-autoroll@skia.org Roll Skia from 89db27b5acb8 to 2135d686708b (1 revision) (flutter/engine#52016) 2024-04-10 skia-flutter-autoroll@skia.org Roll Skia from 1ea5f3cd71cb to 89db27b5acb8 (2 revisions) (flutter/engine#52015) 2024-04-10 skia-flutter-autoroll@skia.org Roll Skia from 14dd5528b318 to 1ea5f3cd71cb (1 revision) (flutter/engine#52014) 2024-04-10 godofredoc@google.com Add postsubmit overrides for mac builders. (flutter/engine#51385) 2024-04-10 flar@google.com [Impeller] NumberNear implements precision-based comparisons (flutter/engine#52001) 2024-04-10 skia-flutter-autoroll@skia.org Roll Skia from 3e3f28d64b2b to 14dd5528b318 (2 revisions) (flutter/engine#52011) 2024-04-10 chinmaygarde@google.com [Impeller] Use type safe masks for HardwareBufferUsage. (flutter/engine#52008) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…6577) flutter/engine@cee489a...0d5412d 2024-04-10 skia-flutter-autoroll@skia.org Roll Skia from 89db27b5acb8 to 2135d686708b (1 revision) (flutter/engine#52016) 2024-04-10 skia-flutter-autoroll@skia.org Roll Skia from 1ea5f3cd71cb to 89db27b5acb8 (2 revisions) (flutter/engine#52015) 2024-04-10 skia-flutter-autoroll@skia.org Roll Skia from 14dd5528b318 to 1ea5f3cd71cb (1 revision) (flutter/engine#52014) 2024-04-10 godofredoc@google.com Add postsubmit overrides for mac builders. (flutter/engine#51385) 2024-04-10 flar@google.com [Impeller] NumberNear implements precision-based comparisons (flutter/engine#52001) 2024-04-10 skia-flutter-autoroll@skia.org Roll Skia from 3e3f28d64b2b to 14dd5528b318 (2 revisions) (flutter/engine#52011) 2024-04-10 chinmaygarde@google.com [Impeller] Use type safe masks for HardwareBufferUsage. (flutter/engine#52008) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#146455
Fuzzy comparisons based on the IEEE floating precision of the numbers being compared will help ensure that comparing large numbers and very small numbers (in unit tests) both have similar accuracy.