This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Expand understanding of build targets in et #51868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johnmccutchan
commented
Apr 3, 2024
- s/TestTarget/BuildTarget.
- Use a more informative way of querying for build targets from gn
- Port existing code to use new interfaces
- Replace 'query tests' with 'query targets' and a --testonly flag
- Extend 'et build' with support for build target selectors.
- Extend 'et query targets' with support for build target selectors.
matanlurey
approved these changes
Apr 3, 2024
cbracken
approved these changes
Apr 3, 2024
Member
cbracken
left a comment
There was a problem hiding this comment.
LGTM in principle, but presubmit is failing.
- s/TestTarget/BuildTarget. - Use a more informative way of querying for build targets. - Port existing code to use new interfaces - Replace 'query tests' with 'query targets' and a --testonly flag - Extend 'et build' with support for build target selectors. - Extend 'et query targets' with support for build target selectors.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 4, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 4, 2024
flutter/engine@918c72b...fa4d97e 2024-04-04 john@johnmccutchan.com Expand understanding of build targets in et (flutter/engine#51868) 2024-04-04 skia-flutter-autoroll@skia.org Roll Skia from 8caa3e2592d5 to d58a6dbaaadb (1 revision) (flutter/engine#51909) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Member
|
I believe it will be useful to have a way to retain the behavior of building the targets specified in the build config json files. Is there some way to work that behavior back into the |
zanderso
reviewed
Apr 5, 2024
| // TODO(johnmccutchan): Reconsider this default or at least lift | ||
| // this logic up to the caller. | ||
| allTargets.values.forEach(selected.add); | ||
| return selected; |
Member
There was a problem hiding this comment.
If you return empty set here, and don't make this an error at the call site of selectTargets, then the extraNinjaTargets parameter of the BuildRunner constructor will be empty, and the targets specified by the build config json will be used.
zanderso
reviewed
Apr 5, 2024
| ]; | ||
|
|
||
| return runBuild(environment, build, extraGnArgs: extraGnArgs); | ||
| final Map<String, BuildTarget> allTargets = await findTargets(environment, |
Member
There was a problem hiding this comment.
This directory might not exist if GN hasn't had a chance to run yet. That is, if you have a fresh engine checkout and out/ is empty, then selectTargets will fail.
zanderso
added a commit
that referenced
this pull request
Apr 8, 2024
…ts (#51956) Addresses the notes I left on #51868. Mainly fixes an issue in which the `build`, `query`, and `test` commands would fail if GN had not yet been run for the requested configuration. Instead, in this PR, if the build output directory doesn't exist yet, then it will run GN before querying the targets. Additionally, for the `build` command, if no targets are specified on the command line, the PR uses the targets in the build config as the default rather than all targets. `query` and `test` keep the same behavior.
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…6299) flutter/engine@918c72b...fa4d97e 2024-04-04 john@johnmccutchan.com Expand understanding of build targets in et (flutter/engine#51868) 2024-04-04 skia-flutter-autoroll@skia.org Roll Skia from 8caa3e2592d5 to d58a6dbaaadb (1 revision) (flutter/engine#51909) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.