This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use moved GrBackendTexture factories for Skia's Metal backend #51828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Apr 2, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 2, 2024
flutter/engine@523fc95...6883f73 2024-04-02 kjlubick@users.noreply.github.com Use moved GrBackendTexture factories for Skia's Metal backend (flutter/engine#51828) 2024-04-02 skia-flutter-autoroll@skia.org Roll Dart SDK from aa6544b48523 to e6e6d5fe3fb0 (1 revision) (flutter/engine#51837) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
hubot
pushed a commit
to google/skia
that referenced
this pull request
Apr 3, 2024
Client CLs: - flutter/engine#51828 Bug: b/293490566 Change-Id: Ida7387579614010d66feb73197e9eecd8c0cc807 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/836216 Commit-Queue: Kevin Lubick <kjlubick@google.com> Auto-Submit: Kevin Lubick <kjlubick@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com> Owners-Override: Kevin Lubick <kjlubick@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://skia-review.googlesource.com/c/skia/+/833302, Skia moved the constructors for Metal versions of GrBackendTexture (and other functions/methods). This updates uses in Flutter to use the new APIs.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.