Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Delegate AppDelegate life-cycle callbacks to plugins via separate object #5173

Merged
sigurdm merged 3 commits into from
May 17, 2018
Merged

Delegate AppDelegate life-cycle callbacks to plugins via separate object #5173

sigurdm merged 3 commits into from
May 17, 2018

Conversation

@sigurdm
Copy link
Contributor

@sigurdm sigurdm commented May 4, 2018

Also moves the plugin registry to FlutterViewController. So each view-controller will handle its
own plugins.

This is intended to simplify including one or more Flutter views in an existing iOS app and giving
more precise control of plugin registration.

Fixes: flutter/flutter#16539

sigurdm added 2 commits May 4, 2018 14:52
@sigurdm
Move the handling of delegating AppDelegate callback out of FlutterAp…
49c7b92 
…pDelegate.

Also moves the plugin registry to FlutterViewController. So each view-controller will handle its
own plugins.

This is intended to simplify including one or more Flutter views in an existing iOS app and giving
more precise control of plugin registration.

Fixes: flutter/flutter#16539
@sigurdm
formatting
236c496
@sigurdm sigurdm requested a review from jakobr-google May 4, 2018 13:01
jakobr-google
jakobr-google approved these changes May 7, 2018
View reviewed changes
Copy link
Contributor

@jakobr-google jakobr-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sigurdm sigurdm requested a review from chinmaygarde May 7, 2018 11:25
@sigurdm
Copy link
Contributor Author

sigurdm commented May 7, 2018

@chinmaygarde do you like the direction this goes?

@sigurdm sigurdm merged commit 597fa9e into flutter:master May 17, 2018
@aam
Copy link
Member

aam commented May 17, 2018

This has broken mac engine buildbot https://build.chromium.org/p/client.flutter/builders/Mac%20Engine/builds/2861/steps/build%20ios_debug_arm/logs/stdio:

FAILED: obj/flutter/shell/platform/darwin/ios/libFlutter/FlutterAppDelegate.o 
/b/build/slave/goma_cache/client/gomacc ../../buildtools/mac-x64/clang/bin/clang++ -MMD -MF obj/flutter/shell/platform/darwin/ios/libFlutter/FlutterAppDelegate.o.d -DFLUTTER_FRAMEWORK -DNO_TCMALLOC -DMEMORY_TOOL_REPLACES_ALLOCATOR -DMEMORY_SANITIZER_INITIAL_SIZE -DTOOLCHAIN_VERSION=ae85410691b10aa2469695c2421b1fe751843e64 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DSK_HAS_JPEG_LIBRARY -DSK_SUPPORT_PDF -DSK_HAS_PNG_LIBRARY -DSK_USE_SKCMS -DSK_HAS_WEBP_LIBRARY -DSK_XML -DFLUTTER_RUNTIME_MODE_DEBUG=1 -DFLUTTER_RUNTIME_MODE_PROFILE=2 -DFLUTTER_RUNTIME_MODE_RELEASE=3 -DFLUTTER_RUNTIME_MODE=1 -DENABLE_OPENTYPE_VERTICAL=1 -DFLUTTER_AOT=1 -DSK_DISABLE_EXPLICIT_GPU_RESOURCE_ALLOCATION -DSK_DISABLE_RENDER_TARGET_SORTING -DSK_SUPPORT_LEGACY_BACKEND_OBJECTS -DSK_DONT_OPTIMIZE_SRC_PROFILES_FOR_SPEED -DSK_DONT_OPTIMIZE_DST_PROFILES_FOR_SPEED -I../.. -Igen -I../.. -I../../garnet/public -I../../topaz/public -Igen/garnet/public -Igen/topaz/public -I../../topaz -I../../third_party/dart/runtime -I../../third_party/skia/include/android -I../../third_party/skia/include/c -I../../third_party/skia/include/codec -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/encode -I../../third_party/skia/include/gpu -I../../third_party/skia/include/gpu/gl -I../../third_party/skia/include/atlastext -I../../third_party/skia/include/pathops -I../../third_party/skia/include/ports -I../../third_party/skia/include/svg -I../../third_party/skia/include/utils -I../../third_party/skia/include/utils/mac -isysroot /Applications/Xcode9.0.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS11.0.sdk -miphoneos-version-min=8.0   -fno-strict-aliasing -arch armv7 -fcolor-diagnostics -Wall -Wextra -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wunguarded-availability -fvisibility=hidden -stdlib=libc++ -Wheader-hygiene -Wstring-conversion -Wthread-safety -Os -fno-ident -fdata-sections -ffunction-sections -g2  -fvisibility-inlines-hidden -fobjc-call-cxx-cdtors -std=c++14 -fno-rtti -fno-exceptions -c ../../flutter/shell/platform/darwin/ios/framework/Source/FlutterAppDelegate.mm -o obj/flutter/shell/platform/darwin/ios/libFlutter/FlutterAppDelegate.o
../../flutter/shell/platform/darwin/ios/framework/Source/FlutterAppDelegate.mm:146:10: error: cannot initialize return object of type 'BOOL' (aka 'signed char') with an rvalue of type 'nullptr_t'
  return nil;
         ^~~
/Applications/Xcode9.0.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS11.0.sdk/usr/include/MacTypes.h:92:19: note: expanded from macro 'nil'
      #define nil nullptr
                  ^~~~~~~
1 error generated.

aam added a commit to aam/engine that referenced this pull request May 17, 2018
@aam
Revert "Delegate AppDelegate life-cycle callbacks to plugins via sepa…
47ecc3a 
…rate object (flutter#5173)"

This reverts commit 597fa9e as it
broke flutter engine mac build bot.
aam added a commit to aam/engine that referenced this pull request May 17, 2018
@aam
Revert "Delegate AppDelegate life-cycle callbacks to plugins via sepa…
edac349 
…rate object (flutter#5173)"

This reverts commit 597fa9e as it broke
mac engine build bot.
@aam aam mentioned this pull request May 17, 2018
Merged
aam added a commit that referenced this pull request May 17, 2018
@aam
Revert "Delegate AppDelegate life-cycle callbacks to plugins via sepa…
65d52d9 
…rate object (#5173)" (#5294)

This reverts commit 597fa9e as it broke
mac engine build bot.
@sigurdm sigurdm mentioned this pull request May 18, 2018
Merged
@mravn-google mravn-google mentioned this pull request Aug 25, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

1 more reviewer

@jakobr-google jakobr-google jakobr-google approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sigurdm @aam @jakobr-google @googlebot