Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@rmacnak-google
Copy link
Contributor

@rmacnak-google rmacnak-google commented Mar 25, 2024

The engine is not compatible with newer versions of zlib that Dart needs to unblock toolchain rolls.

@rmacnak-google rmacnak-google requested a review from aam March 26, 2024 18:03
Copy link
Member

@aam aam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmacnak-google rmacnak-google merged commit baede78 into flutter:main Mar 26, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 26, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 26, 2024
flutter/engine@cffd1dc...baede78

2024-03-26 rmacnak@google.com Stop rolling zlib with Dart SDK rolls. (flutter/engine#51667)
2024-03-26 skia-flutter-autoroll@skia.org Roll Skia from 90cfbf5fb91e to 0590062821dc (2 revisions) (flutter/engine#51680)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants