Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@chinmaygarde
Copy link
Contributor

These are files that the license script ignores.

These are files that the license script ignores.
@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 18, 2024

auto label is removed for flutter/engine/51496, due to - The status or check suite Linux linux_license has failed. Please fix the issues identified (or deflake) before re-applying this label.

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2024
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #51496 at sha b4a25a3

@chinmaygarde
Copy link
Contributor Author

Gold seems to have taken a screenshot of the device before (or after) the app was launched. In any case, I only changed comments in this patch.
Screenshot 2024-03-18 at 3 33 17 PM

@chinmaygarde chinmaygarde merged commit 506bc1c into flutter:main Mar 19, 2024
@chinmaygarde chinmaygarde deleted the missing_licenses branch March 19, 2024 03:47
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 19, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 19, 2024
flutter/engine@4a86b5b...ac8f1f2

2024-03-19 skia-flutter-autoroll@skia.org Roll Skia from f5d824314bf7 to 86de9a698b76 (2 revisions) (flutter/engine#51510)
2024-03-19 chinmaygarde@google.com Add missing license blocks. (flutter/engine#51496)
2024-03-19 skia-flutter-autoroll@skia.org Roll Dart SDK from f874a4976038 to 3e64b8fcbfb7 (1 revision) (flutter/engine#51509)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants