This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Update Linux embedder to latest semantics API #51030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58bcb23 to
e427e0a
Compare
cbracken
approved these changes
Feb 28, 2024
Contributor
Author
|
I'm confused by the formatting failure - it's in files not changed by this PR and it doesn't match the output of clang-format here. |
Member
Odd... I wonder if something changed in the way we do the presubmits; we definitely used to intentionally exclude unmodified files. I've kicked off a re-run in the desperate hope that somehow it rights itself.
You're using the clang-format from the toolchain in our buildroot as opposed to a locally-installed version? |
Contributor
Author
|
I have been using the locally installed version which used to match, perhaps it doesn't anymore. |
Contributor
Author
|
Seems to be fixed on main already. |
This class didn't match the other plugins - it didn't have any channels to the engine. Since it wasn't doing anything, remove it.
7be77b8 to
31c9547
Compare
Contributor
Author
|
Ah, I did include formatting changes by accident, I've stripped them out now. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 29, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 29, 2024
flutter/engine@9e18761...232217f 2024-02-29 robert.ancell@canonical.com Update Linux embedder to latest semantics API (flutter/engine#51030) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to the latest semantics API and remove an unused class.