This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[et] Improve the logger for the ninja build, adds a spinner #50952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| config.name: config.gn.join(' '), | ||
| }, | ||
| ) | ||
| ..addFlag( |
Contributor
There was a problem hiding this comment.
I don't think we should overload 'build' to also run tests. We should instead add a separate 'test' command.
Member
Author
There was a problem hiding this comment.
Makes sense. I removed this flag, and hardcoded the option in the build config runner to false.
c7dc1f7 to
04d8a28
Compare
johnmccutchan
approved these changes
Feb 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 26, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 26, 2024
flutter/engine@34a8b9b...04ff286 2024-02-26 zanderso@users.noreply.github.com [et] Improve the logger for the ninja build, adds a spinner (flutter/engine#50952) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For flutter/flutter#132807
The spinner is mostly copied from the flutter_tool.