Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Feb 12, 2024

Improves Windows's lifecycle event for window destruction:

  1. Made FlutterWindowsView generate the "window hidden" event when the HWND is destroyed instead of the FlutterWindow.
    1. Before the window would submit this event using a destroyed view:
      1. The FlutterWindowsView destructor runs to completion.
      2. The view owns the window, so the FlutterWindow is destroyed
      3. The window's destructor generates a "window hidden" event
      4. The window uses the destroyed view to notify the engine of the event
  2. Adds an app lifecycle integration test to verify the resumed and hidden events are sent when an app is launched and closed.
  3. Removed the FlutterWindowTest type as it was unused

Prepares for flutter/flutter#137267
Prepares for flutter/flutter#142845

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@loic-sharma loic-sharma changed the title [Windows] Improve window destroyed lifecycle event [Windows] Refactor window destroyed app lifecycle event Feb 12, 2024
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

Nice!

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2024
@auto-submit auto-submit bot merged commit abb51c4 into flutter:main Feb 13, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 13, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 14, 2024
flutter/engine@9b18387...abb51c4

2024-02-13 737941+loic-sharma@users.noreply.github.com [Windows] Refactor window destroyed app lifecycle event (flutter/engine#50565)
2024-02-13 jonahwilliams@google.com [Impeller] fix cmd buffer recycling bug in test. (flutter/engine#50615)
2024-02-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 04caefbfa60f to a8303c0bf1b4 (1 revision) (flutter/engine#50614)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

affects: desktop autosubmit Merge PR when tree becomes green via auto submit App platform-windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants