This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] blur: drop eighth downsample barrier #50405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
reviewed
Feb 6, 2024
Comment on lines
230
to
231
| // This constant was picked by looking at the results in to make sure no | ||
| // shimmering was introduced. |
Member
There was a problem hiding this comment.
Looks like there's a missing word or words in this comment in "looking at the results in to make sure...".
Member
Author
There was a problem hiding this comment.
done, fixed and expanded
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 8, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 8, 2024
flutter/engine@f53fbd8...3fb60b8 2024-02-08 30870216+gaaclarke@users.noreply.github.com [Impeller] blur: drop eighth downsample barrier (flutter/engine#50405) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: flutter/flutter#142990
I pushed this value as low as I dared to go and ended up with a kernel size of 41 (radius 20). This means the range of sigma ~60 to ~70 will now be 1/16th scalar instead of 1/8th.
Here is the new downsample rate versus sigma on a 2x display.
before
after
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.