This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Avoid sizing ImageReaderSurfaceProducer smaller than 1x1
#50066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assertEquals(texture.getHeight(), 1); | ||
|
|
||
| // Try setting width and height to 0. | ||
| texture.setSize(0, 0); |
Contributor
There was a problem hiding this comment.
I would call getSurface after setSize(0,0) and make sure that it doesn't raise an exception.
johnmccutchan
approved these changes
Jan 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 26, 2024
flutter/engine@9142fc4...8a81e53 2024-01-26 skia-flutter-autoroll@skia.org Roll Dart SDK from 00784f1f22b5 to 6f8bcd5b48ab (1 revision) (flutter/engine#50074) 2024-01-26 ditman@gmail.com [web] Add `views` proxy and `getInitialData`. (flutter/engine#49320) 2024-01-26 ditman@gmail.com [web] Prevent re-rendering disposed views when the engine hot restarts. (flutter/engine#49958) 2024-01-26 skia-flutter-autoroll@skia.org Roll Dart SDK from 2fb950853f06 to 00784f1f22b5 (3 revisions) (flutter/engine#50068) 2024-01-26 matanlurey@users.noreply.github.com Avoid sizing `ImageReaderSurfaceProducer` smaller than 1x1 (flutter/engine#50066) 2024-01-26 jonahwilliams@google.com Use clamp sampling mode in external texture. (flutter/engine#50063) 2024-01-26 john@johnmccutchan.com Reland Optimizations for TLHC frame rate and jank (flutter/engine#50065) 2024-01-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Igt2rE-R6rgfmTRaF... to WHlwlOwznFknNm5IS... (flutter/engine#50059) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Igt2rE-R6rgf to WHlwlOwznFkn If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
…s. (#50144) Reverts #50065 due to flutter/flutter#142459. [Discord](https://discord.com/channels/608014603317936148/608020293944082452/1201589744690270338): > It looks like the failing tests are the resize tests for webview_flutter and google_maps_flutter I can reproduce the failure locally for: https://github.com/flutter/packages/blob/main/packages/webview_flutter/webview_flutter_android/example/integration_test/webview_flutter_test.dart#L296 I manually merged this to keep #50066.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix towards flutter/flutter#142082.
This fixes OpenGLES + SurfaceProducer, but not Vulkan + SurfaceProducer (that requires VK-specific changes).