This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove fuchsia from allowed_hosts post-migration #50013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 25, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 26, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 26, 2024
…42278) Manual roll requested by zra@google.com flutter/engine@4b145d0...9142fc4 2024-01-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Optimizations for TLHC frame rate and jank" (flutter/engine#50062) 2024-01-25 bdero@google.com [Impeller] Fix advanced blend alpha issue, improve blend goldens. (flutter/engine#50035) 2024-01-25 127441427+eitanliu@users.noreply.github.com Fix android new engine in group (flutter/engine#49659) 2024-01-25 103135467+sealesj@users.noreply.github.com Remove fuchsia from allowed_hosts post-migration (flutter/engine#50013) 2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 801bb44f2b09 to cc5124317c18 (1 revision) (flutter/engine#50054) 2024-01-25 leroux_bruno@yahoo.fr Fix a typo in ChannelBuffers documentation (flutter/engine#49928) 2024-01-25 dnfield@google.com Add include suggested by clang-tidy (flutter/engine#49898) 2024-01-25 smartercallum@gmail.com Refactor macOS trackpad gesture tracking (flutter/engine#49424) 2024-01-25 148634283+nikkivirtuoso@users.noreply.github.com winding order from tesellator.h to formats.h (flutter/engine#49865) 2024-01-25 ian@hixie.ch Roll webp to 1.3.2 (flutter/engine#49883) 2024-01-25 john@johnmccutchan.com Optimizations for TLHC frame rate and jank (flutter/engine#50033) 2024-01-25 skia-flutter-autoroll@skia.org Roll Skia from 29b545e4356b to 801bb44f2b09 (1 revision) (flutter/engine#50051) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuchsia is no longer referenced as a host for dependencies and should not be in the future. This change removes the host from allowed_hosts.
Also included is a cleanup of the ocmock comment since there is now a flutter mirror and there will not be more github references directly in the future.
Verified that this change passes
gclient verify(with the exception of thebuildrootdependency which fails because of github not being in allowed_hosts, not because of the fuchsia change).Addresses b/308986699
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.