This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Roll dart to 4bcf8ad411bd90da16d44ad399bf350e8423eac9 #4929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit log in this range: e01fbec Fix type in NativeTypedArrayOfDouble 8d78982 Move file system access support from AnalysisContext to ContextRoot 7b51acd [vm/kernel/aot] Treat 'return;' as 'return null;' in TFA 3ba478a Remove SDK browser DEP bfb9fae [vm] Don't keep events in memory when using systrace/traceutil. 1daa813 Improve fasta parser enum declaration recovery fabc51b Silence parser recovery tests. feceb2c Restore ErrorCode default constructor, rename the one with named parameters to 'temporary'. 616acb0 Deprecate the option to enable using a URI in a part-of directive 374058a Improve fasta parser try/catch error messages and recovery 79a349f Don't put libraries of all analyzed units into the current session. a0470fe Remove implicit_creation/implicit_new_or_const_composite_test from the status file under darkp as the test now passes. 0c892a8 Improve signatures of tear-offs 9858ea1 Explicitly store isIntercepted in full emitter tearoffs a60b4d6 [kernel/vm/aot] De-duplicate identical mixin applications 3db2338 [vm] Remove old --break_at_isolate_spawn. 5941ebc [observatory] Filter platform dil files. 996a66d Fix build bot failure in dartkp mode (language_2/implicit_creation/implicit_new_or_const_test now passes) 76db550 Bring in the latest pub and pub_semver c1432bf [observatory] Remove references to pkg:browser from web/index.html
aam
reviewed
Apr 3, 2018
| 'dart_protobuf_tag': '0.7.1', | ||
| 'dart_pub_rev': '875d35005a7d33f367d70a3e31e9d3bad5d1ebd8', | ||
| 'dart_pub_semver_tag': '1.3.2', | ||
| 'dart_pub_rev': '4947e0b3cb3ec77e4e8fe0d3141ce4dc60f43256', |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has the issue dart-lang/pub#1853 with pub was indeed resolved in this revision, do you know?
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue you raised has been closed, let me try out your test to ensure that it works.
aam
approved these changes
Apr 3, 2018
a-siva
added a commit
that referenced
this pull request
Apr 4, 2018
This was referenced Apr 4, 2018
a-siva
added a commit
that referenced
this pull request
Apr 4, 2018
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Apr 5, 2018
Includes: * Revert "Roll dart to 4bcf8ad411bd90da16d44ad399bf350e8423eac9" (flutter/engine#4936) * libtxt: render fake bold text if a bold font is not available (flutter/engine#4933) * Set FlutterTexture copyPixelBuffer return nullable (flutter/engine#4934) * Roll dart to 4bcf8ad411bd90da16d44ad399bf350e8423eac9 (flutter/engine#4929)
cbracken
added a commit
to flutter/flutter
that referenced
this pull request
Apr 5, 2018
Includes: * Revert "Roll dart to 4bcf8ad411bd90da16d44ad399bf350e8423eac9" (flutter/engine#4936) * libtxt: render fake bold text if a bold font is not available (flutter/engine#4933) * Set FlutterTexture copyPixelBuffer return nullable (flutter/engine#4934) * Roll dart to 4bcf8ad411bd90da16d44ad399bf350e8423eac9 (flutter/engine#4929)
harrisonturton
pushed a commit
to harrisonturton/flutter
that referenced
this pull request
Apr 5, 2018
Includes: * Revert "Roll dart to 4bcf8ad411bd90da16d44ad399bf350e8423eac9" (flutter/engine#4936) * libtxt: render fake bold text if a bold font is not available (flutter/engine#4933) * Set FlutterTexture copyPixelBuffer return nullable (flutter/engine#4934) * Roll dart to 4bcf8ad411bd90da16d44ad399bf350e8423eac9 (flutter/engine#4929)
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
Includes: * Revert "Roll dart to 4bcf8ad411bd90da16d44ad399bf350e8423eac9" (flutter/engine#4936) * libtxt: render fake bold text if a bold font is not available (flutter/engine#4933) * Set FlutterTexture copyPixelBuffer return nullable (flutter/engine#4934) * Roll dart to 4bcf8ad411bd90da16d44ad399bf350e8423eac9 (flutter/engine#4929)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit log in this range:
4bcf8ad [fasta] Handle static get in ConstnessEvaluator
2642314 [infra] Add dart2js-chrome to the CQ again
b879d4d [fasta] Fix insertion of noSuchMethod forwarders for private members
e3ace23 [infra] Remove dart2js-chrome from the CQ temporarily
d0ad78d Improve recovery when "set" found in function body
5367304 Cleanup in incremental compiler
8ac9fa5 Rename simple to basic; get rid of name in tests
4b2b15f Clarify that mixin application drops static members
cb08bf2 [infra] Expect certain errors to pass when runtime is "none"
b793c8a [fasta] Require explicit handling of all expression kinds in ConstnessEvaluator
4c6379e [infra] Support preview_dart_2 in status update tool
1b696eb [infra] Print variable name for unknown variables
1dfb1c2 Implement Dart 2 static subtyping
163f8b9 Cleanup async stack recording
b07a4bc improve deduping of cached types in DDC/K
54f7680 fix DDC dynamic call profiler to ignore SDK frames
a4c5607 fix #32594,
debugger()will work even if dart_sdk.js is blackboxedc5caf7e dart2js: Pass through type arguments in parameter defaulting stubs
a0a06e1 Bring in the latest pub_semver
4089111 Revert "Revert "Don't do implicit new/const code generation with --preview-dart-2 enabled.""
e5d20a7 Add type to loadLibrary tearoff
bec3801 Improve recovery when mixin app missing "with" clause
701e02b Update AstBuilder to handle named function declaration
ddbe2ee Change assertions in SSA so that it checks up to 100 instructions. This cuts down compilation time for some very slow tests by a third.
d39e5cc [vm/compiler] Fix assignment of type to phi, take 2
a173784 Readd web-components: it is used for unit tests of dart:html
57d6ec2 Improve AstBuilder for-in recovery
0ea0c42 Extract AnalysisDriverResolutionTest and corresponding Kernel version into separate files.
ca7edd0 Improve invalid function body recovery
8341843 Issue 32740. Support for implicit call() invocation in top-level inference.
38fae02 Allow to output full component via computeDelta
c98df5b Check that type alias equality relies on the underlying type, not the
typedefed name.155e55c Remove defaultValue parameter from Stream.first/lastWhere.
0588816 Move type_representation_test to rti/ folder
0ba21c2 Clean up Map#operator[] documentation
e01fbec Fix type in NativeTypedArrayOfDouble
8d78982 Move file system access support from AnalysisContext to ContextRoot
7b51acd [vm/kernel/aot] Treat 'return;' as 'return null;' in TFA
3ba478a Remove SDK browser DEP
bfb9fae [vm] Don't keep events in memory when using systrace/traceutil.
1daa813 Improve fasta parser enum declaration recovery
fabc51b Silence parser recovery tests.
feceb2c Restore ErrorCode default constructor, rename the one with named parameters to 'temporary'.
616acb0 Deprecate the option to enable using a URI in a part-of directive
374058a Improve fasta parser try/catch error messages and recovery
79a349f Don't put libraries of all analyzed units into the current session.
a0470fe Remove implicit_creation/implicit_new_or_const_composite_test from the status file under darkp as the test now passes.
0c892a8 Improve signatures of tear-offs
9858ea1 Explicitly store isIntercepted in full emitter tearoffs
a60b4d6 [kernel/vm/aot] De-duplicate identical mixin applications
3db2338 [vm] Remove old --break_at_isolate_spawn.
5941ebc [observatory] Filter platform dil files.
996a66d Fix build bot failure in dartkp mode (language_2/implicit_creation/implicit_new_or_const_test now passes)
76db550 Bring in the latest pub and pub_semver
c1432bf [observatory] Remove references to pkg:browser from web/index.html