This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Set the asset bundle path when initializing the shell in the embedder API #4925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… API This is required so that Dart initialization can find the platform kernel assets when running in Dart 2 mode
Member
Author
tvolkert
approved these changes
Apr 2, 2018
Contributor
|
Would this also cause google/flutter-desktop-embedding#33 ? |
Member
Author
|
I don't have a MacOS environment set up to test it, but based on the stack trace in google/flutter-desktop-embedding#33 I suspect that this is the same issue. Without this patch, |
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Apr 4, 2018
Includes: * libtxt: add missing dependency for Mac/iOS builds (flutter/engine#4931) * libtxt: use Helvetica as a fallback font on iOS 8 and earlier (flutter/engine#4930) * Make Rect.largest match the "largest" rect used in DefaultLayerBuilder (flutter/engine#4926) * [vulkan] Add VK_ERROR_NOT_PERMITTED_EXT * Roll buildroot to 8dddd90 (flutter/engine#4928) * Set the asset bundle path when initializing the shell in the embedder API (flutter/engine#4925)
cbracken
added a commit
to flutter/flutter
that referenced
this pull request
Apr 4, 2018
Includes: * libtxt: add missing dependency for Mac/iOS builds (flutter/engine#4931) * libtxt: use Helvetica as a fallback font on iOS 8 and earlier (flutter/engine#4930) * Make Rect.largest match the "largest" rect used in DefaultLayerBuilder (flutter/engine#4926) * [vulkan] Add VK_ERROR_NOT_PERMITTED_EXT * Roll buildroot to 8dddd90 (flutter/engine#4928) * Set the asset bundle path when initializing the shell in the embedder API (flutter/engine#4925)
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
Includes: * libtxt: add missing dependency for Mac/iOS builds (flutter/engine#4931) * libtxt: use Helvetica as a fallback font on iOS 8 and earlier (flutter/engine#4930) * Make Rect.largest match the "largest" rect used in DefaultLayerBuilder (flutter/engine#4926) * [vulkan] Add VK_ERROR_NOT_PERMITTED_EXT * Roll buildroot to 8dddd90 (flutter/engine#4928) * Set the asset bundle path when initializing the shell in the embedder API (flutter/engine#4925)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required so that Dart initialization can find the platform kernel
assets when running in Dart 2 mode