This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Rolls clang to 725656bdd885483c39f482a01ea25d67acf39c46 #49248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flar
approved these changes
Dec 19, 2023
Contributor
flar
left a comment
There was a problem hiding this comment.
Just to clarify (chatted with Zach offline about this), but the new asserts are required to prove to clang-tidy that the values can't be null otherwise it thinks we have a problem there.
LGTM
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 19, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 19, 2023
flutter/engine@3b156c8...df1593e 2023-12-19 zanderso@users.noreply.github.com Rolls clang to 725656bdd885483c39f482a01ea25d67acf39c46 (flutter/engine#49248) 2023-12-19 aam@google.com Roll dart to 3.3.0-242.0.dev (flutter/engine#49239) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CoderDake
pushed a commit
to CoderDake/flutter
that referenced
this pull request
Dec 28, 2023
…0422) flutter/engine@3b156c8...df1593e 2023-12-19 zanderso@users.noreply.github.com Rolls clang to 725656bdd885483c39f482a01ea25d67acf39c46 (flutter/engine#49248) 2023-12-19 aam@google.com Roll dart to 3.3.0-242.0.dev (flutter/engine#49239) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're on a version of clang that crashes a lot on macOS. This PR rolls clang forward to a new release from the Fuchsia toolchain team. If it does not fix the crash, we can roll back with #49249. Both rolling forward and back require the fixes to the
.mmfile in this PR.