Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Dec 15, 2023

This is a temporary workaround to get mouse cursor working in multi-view (until flutter/flutter#140226 is resolved).

@mdebbar mdebbar requested a review from ditman December 15, 2023 18:38
@github-actions github-actions bot added the platform-web Code specifically for the web engine label Dec 15, 2023
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This will do nicely for now!

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 18, 2023
@auto-submit auto-submit bot merged commit e4fa972 into flutter:main Dec 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 18, 2023
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Dec 18, 2023
flutter/engine@d7f0803...e4fa972

2023-12-18 mdebbar@google.com [web] Set cursor property on body (flutter/engine#49098)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@mdebbar mdebbar deleted the multi_view_cursor branch December 18, 2023 18:29
CoderDake pushed a commit to CoderDake/flutter that referenced this pull request Dec 28, 2023
)

flutter/engine@d7f0803...e4fa972

2023-12-18 mdebbar@google.com [web] Set cursor property on body (flutter/engine#49098)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants