Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@matanlurey
Copy link
Contributor

No description provided.

@matanlurey matanlurey added the test: all See https://github.com/flutter/engine/blob/main/docs/ci/Engine-pre-submits-and-post-submits.md label Nov 16, 2023
@matanlurey matanlurey marked this pull request as ready for review November 17, 2023 23:07
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matanlurey matanlurey merged commit 66f764a into flutter:main Nov 17, 2023
@matanlurey matanlurey deleted the engien-tidy-testing-vulkan branch November 17, 2023 23:16
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 18, 2023
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Nov 18, 2023
flutter/engine@1d2ee54...66f764a

2023-11-17 matanlurey@users.noreply.github.com Make `testing/...` and `vulkan/...` compatible with `.clang-tidy`. (flutter/engine#48161)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

test: all See https://github.com/flutter/engine/blob/main/docs/ci/Engine-pre-submits-and-post-submits.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants