This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Make display_list/... compatible with .clang_tidy.
#48147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Friendly ping @flar. + @jonahwilliams as well in case Jim is out. |
flar
approved these changes
Nov 17, 2023
Contributor
flar
left a comment
There was a problem hiding this comment.
LGTM - other than the missing space
| STROKE_BENCHMARKS(BACKEND, kStrokedStyle) \ | ||
| STROKE_BENCHMARKS(BACKEND, kStrokedStyle | kAntiAliasing) \ | ||
| STROKE_BENCHMARKS(BACKEND, kStrokedStyle | kHairlineStroke) \ | ||
| STROKE_BENCHMARKS(BACKEND, kStrokedStyle| kHairlineStroke | \ |
Contributor
There was a problem hiding this comment.
Looks like a missing space before the | operator
Contributor
There was a problem hiding this comment.
Oh, and the \ at the ends of lines should line up. Also seen in other of these changes...
Contributor
There was a problem hiding this comment.
Sorry, removed the autosubmit pending fixing the alignment of the line ends...
Contributor
Author
There was a problem hiding this comment.
Should be fixed now.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 18, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 18, 2023
flutter/engine@66f764a...5f40c9f 2023-11-18 matanlurey@users.noreply.github.com Make `display_list/...` compatible with `.clang_tidy`. (flutter/engine#48147) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.