This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[engine] request frame rate once per frame. #47954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
approved these changes
Nov 13, 2023
| explicit StopwatchVisualizer(const Stopwatch& stopwatch) | ||
| : stopwatch_(stopwatch) {} | ||
| : stopwatch_(stopwatch) { | ||
| frame_budget_ = stopwatch_.GetFrameBudget(); |
Contributor
There was a problem hiding this comment.
Let's note why this is happening so someone doesn't refactor it back in the future (it won't be clear this is a JNI call).
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 13, 2023
flutter/engine@74ba6c1...db6da00 2023-11-13 jonahwilliams@google.com [Impeller] Add convex tess benchmark. (flutter/engine#47956) 2023-11-13 jonahwilliams@google.com [engine] request frame rate once per frame. (flutter/engine#47954) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current stopwatch design, we request the frame rate multiple times per frame. On Android this calls into JNI which is pretty slow. If we cache the value at construction of the StopwatchVisualizer, then we will only compute it once per frame (because the StopwatchVisualizer is reconstructed each frame).
Fixes flutter/flutter#137797
So the issue isn't that we're checking the fresh rate every frame, its that we were checking N times on each frame.