Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Switch to Android 14 for physical device firebase tests #47016

Merged
auto-submit merged 2 commits into from
Nov 8, 2023
Merged

Switch to Android 14 for physical device firebase tests #47016

auto-submit merged 2 commits into from
Nov 8, 2023

Conversation

@gmackall
Copy link
Member

@gmackall gmackall commented Oct 17, 2023 •
edited
Loading

Switch to the latest android version for tests.

Device is high capacity, and currently in use in flutter/flutter. See here to get the list of devices.

Related to flutter/flutter#136736

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gmackall
Copy link
Member Author

gmackall commented Oct 17, 2023

It's actually not clear to me that this configuration is being used at all. Asked about it in #hackers-engine, anyone who finds this can ignore for now (unless you know the answer, then please let me know!)

@gmackall
Copy link
Member Author

gmackall commented Oct 23, 2023

Blocked on flutter/flutter#136767

@gmackall
Copy link
Member Author

gmackall commented Nov 8, 2023

This is no longer blocked so marking as ready for review

@gmackall gmackall marked this pull request as ready for review November 8, 2023 17:56
@gmackall gmackall requested a review from a team November 8, 2023 17:56
@gmackall
Copy link
Member Author

gmackall commented Nov 8, 2023

Looks like the Linux linux_android_aot_engine test failed the first run because the android_profile_arm64 sub-test crashed during the firebase testing.

https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_android_aot_engine/21164/overview
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/1582941/overview

Crashed with the error

java.lang.NullPointerException: Attempt to invoke virtual method 'io.flutter.embedding.engine.FlutterEngine io.flutter.embedding.android.FlutterActivityAndFragmentDelegate.getFlutterEngine()' on a null object reference
     FATAL EXCEPTION: main
Process: dev.flutter.scenarios, PID: 17095
java.lang.NullPointerException: Attempt to invoke virtual method 'io.flutter.embedding.engine.FlutterEngine io.flutter.embedding.android.FlutterActivityAndFragmentDelegate.getFlutterEngine()' on a null object reference
	at io.flutter.embedding.android.FlutterActivity.getFlutterEngine(FlutterActivity.java:1232)
	at dev.flutter.scenarios.TestActivity.writeTimelineData(TestActivity.java:107)
	at dev.flutter.scenarios.TestActivity$1.run(TestActivity.java:56)
	at android.os.Handler.handleCallback(Handler.java:958)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:205)
	at android.os.Looper.loop(Looper.java:294)
	at android.app.ActivityThread.main(ActivityThread.java:8177)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:971)

It seems to have passed on re-run

@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 8, 2023
@auto-submit auto-submit bot merged commit 5306213 into flutter:main Nov 8, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 8, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2023
@engine-flutter-autoroll
5306213 Switch to Android 14 for physical device firebase tests (flut…
2b8fd06 
…ter/engine#47016)
fluttermirroringbot pushed a commit to flutter/flutter that referenced this pull request Nov 8, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 6dbcf8f to 5306213 (4 revisions) (#138108)
8b2e5b3 
flutter/engine@6dbcf8f...5306213

2023-11-08 34871572+gmackall@users.noreply.github.com Switch to Android 14 for physical device firebase tests (flutter/engine#47016)
2023-11-08 jonahwilliams@google.com [Impeller] remove capability to read from onscreen. (flutter/engine#47808)
2023-11-08 skia-flutter-autoroll@skia.org Roll Skia from a4cce5236dcf to fb69e696dc45 (1 revision) (flutter/engine#47810)
2023-11-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 15c286ed91ea to 14933042494d (5 revisions) (flutter/engine#47805)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@camsim99 camsim99 camsim99 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gmackall @camsim99